Repository navigation
fix: keep filter chips in sync with the URL on back and forward - #3699
Merged
Merged
Conversation
Closed
2 tasks done
This was referenced Oct 13, 2026
JammingBen
reviewed
Oct 13, 2026
JammingBen
left a comment
Member
There was a problem hiding this comment.
This fixes some of the filters, but not all: The "hidden"-filter on the Shared with me page and the user search filter in the admin-settings don't follow back.
Member
Author
JammingBen
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
selectionChangeonly when the selection really changed. This keeps the chips in sync in all views that use it: search, Favorites, Shared with me, Shared with others and admin Users.ItemFilterstill exposessetSelectedItemsBasedOnQuery, now marked@deprecatedbecause the filter follows the route query by itself.router.replaceinstead ofpushwhen a filter changes, so Forward keeps working after going Back.Related Issue
How Has This Been Tested?
selectionChangewhen its query param is removed from the routeq_tagsis removed from the route (real router and real ItemFilter)router.replaceand notrouter.pushwhen the groups filter changestoggleFilterwhen its query param is removed from the routesetSelectedItemsBasedOnQueryTypes of changes