Skip to content

fix(web-runtime): handle wrong passwords on the public link page - #3592

Merged
AlexAndBear merged 3 commits into
mainfrom
fix/public-link-page-errors
Oct 13, 2026
Merged

AlexAndBear merged 3 commits into
mainfrom
fix/public-link-page-errors

Conversation

@AlexAndBear

@AlexAndBear AlexAndBear commented Oct 7, 2026 •

Copy link
Copy Markdown
Member

Description

  • Wrong password: entering a wrong password on the public link page no longer throws an unhandled error, “Incorrect password” is shown as before.

Related Issue

  • No issue, found in the functional bug sweep of the web client

How Has This Been Tested?

  • test environment: local dev server, Playwright (Chromium)
  • wrong password: “Incorrect password”, no pageerror; the correct one opens the link
  • unit tests added

Types of changes

  • Bugfix
  • Enhancement (a change that doesn't break existing code or deployments)
  • Breaking change (a modification that affects current functionality)
  • Technical debt (addressing code that needs refactoring or improvements)
  • Tests (adding or improving tests)
  • Documentation (updates or additions to documentation)
  • Maintenance (like dependency updates or tooling adjustments)

@JammingBen JammingBen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally unsure if we really need this? OpenCloud Web never had internal links, it was removed long before. Technically a user can create such a link via the API, but do we really need fallbacks in the UI for users exploiting left-over features from before OpenCloud?

Comment thread packages/web-runtime/src/pages/resolvePublicLink.vue Outdated
Co-authored-by: Jannik Stehle <50302941+JammingBen@users.noreply.github.com>
@AlexAndBear AlexAndBear changed the title fix(web-runtime): handle internal links and wrong passwords on the public link page fix(web-runtime): handle wrong passwords on the public link page Oct 12, 2026
@AlexAndBear

Copy link
Copy Markdown
Member Author

Correction: internal links aren't supported anymore and we already removed their code elsewhere, so we shouldn't carry a fallback for them. Dropped the internal link handling in 0a38d76, this PR now only fixes the wrong password error.

@AlexAndBear
AlexAndBear merged commit ef76c3c into main Oct 13, 2026
31 checks passed
@AlexAndBear
AlexAndBear deleted the fix/public-link-page-errors branch October 13, 2026 06:48
@openclouders openclouders mentioned this pull request Oct 13, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants