Repository navigation
fix(web-runtime): handle wrong passwords on the public link page - #3592
Merged
Merged
Conversation
JammingBen
reviewed
Oct 8, 2026
JammingBen
left a comment
Member
There was a problem hiding this comment.
Generally unsure if we really need this? OpenCloud Web never had internal links, it was removed long before. Technically a user can create such a link via the API, but do we really need fallbacks in the UI for users exploiting left-over features from before OpenCloud?
Co-authored-by: Jannik Stehle <50302941+JammingBen@users.noreply.github.com>
Member
Author
|
Correction: internal links aren't supported anymore and we already removed their code elsewhere, so we shouldn't carry a fallback for them. Dropped the internal link handling in 0a38d76, this PR now only fixes the wrong password error. |
JammingBen
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
How Has This Been Tested?
Types of changes