Skip to content

feat: polish announcement banner and details modal - #3442

Merged
AlexAndBear merged 6 commits into
mainfrom
fix/announcement-banner-polish
Sep 25, 2026
Merged

AlexAndBear merged 6 commits into
mainfrom
fix/announcement-banner-polish

Conversation

@AlexAndBear

@AlexAndBear AlexAndBear commented Sep 24, 2026 •

Copy link
Copy Markdown
Member

Description

Before

image

After

image

Polishes the announcement banner (introduced in #2967) and its details modal.

Banner

  • The banner text is now left-aligned and bold.
  • When the announcement has info text, the whole banner area (full height, up to the divider) is a single button that opens the details modal. A Details label with a right chevron is shown at its right end, separated from the dismiss button by a vertical divider.
    • Why: until now, the only way to open the details was clicking the banner text itself. Regular users won't necessarily know that the text is clickable, so the details were easy to miss. The explicit "Details" label makes the action discoverable, while the large click target keeps it easy to hit.
  • No hover underline on the banner text, consistent with the rest of the UI.

Details modal

  • The content is wrapped in an oc-section that uses the banner text as its title and the same information icon as the banner (not expandable, no subtitle). The modal header now reads "Announcement", so the banner text isn't shown twice.
  • The "Close" button at the bottom was removed. The modal is closed with the standard close button at the top right, to be consistent with all other modals.

Related Issue

How Has This Been Tested?

  • test environment: local dev setup, unit tests (Vitest)
  • test case 1: banner with info text shows a left-aligned bold text, a "Details" label at the right end of the banner button and the dismiss button; clicking anywhere on the banner button opens the modal
  • test case 2: banner without info text shows no "Details" label and the text is not clickable
  • test case 3: the modal shows the banner text as section title with the info icon and can only be closed via the top right close button
  • e2e helper updated to open the modal via the "Details" label and close it via the top right close button

Types of changes

  • Bugfix
  • Enhancement (a change that doesn't break existing code or deployments)
  • Breaking change (a modification that affects current functionality)
  • Technical debt (addressing code that needs refactoring or improvements)
  • Tests (adding or improving tests)
  • Documentation (updates or additions to documentation)
  • Maintenance (like dependency updates or tooling adjustments)

@AlexAndBear AlexAndBear self-assigned this Sep 24, 2026
@AlexAndBear
AlexAndBear requested a review from kulmann September 24, 2026 03:25
@github-project-automation github-project-automation Bot moved this to Qualification in OpenCloud Team Board Sep 24, 2026
@AlexAndBear AlexAndBear moved this from Qualification to In Progress in OpenCloud Team Board Sep 24, 2026

@dschmidt dschmidt left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not the biggest fan of the "Announcement" header in the modal, otherwise I'm pretty much without any emotion towards this change.

@AlexAndBear
AlexAndBear force-pushed the fix/announcement-banner-polish branch from f36a7d4 to 4c04031 Compare September 25, 2026 09:13
@AlexAndBear
AlexAndBear merged commit f66cda8 into main Sep 25, 2026
31 checks passed
@AlexAndBear
AlexAndBear deleted the fix/announcement-banner-polish branch September 25, 2026 11:27
@openclouders openclouders mentioned this pull request Sep 25, 2026
1 task
@AlexAndBear AlexAndBear changed the title fix: polish announcement banner and details modal feat: polish announcement banner and details modal Sep 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants