Repository navigation
using sdpa if available - #2359
Merged
Merged
Conversation
jongwook
force-pushed
the
jongwook/sdpa
branch
from
September 30, 2024 17:12
8b5b497 to
65a3537
Compare
|
I encountered an issue with this patch. In this part of the code of model.py: Somehow we got Tensor and not a boolean in is_causal. If mask is a tensor, the resulting is_causal can itself be a tensor, depending on how it is handled. So maybe a potential solution would be to cast it as bool like: |
|
I have the same issue as @formater where is_causal is receiving a Tensor instead of a bool. |
hiden47
pushed a commit
to hiden47/whisper
that referenced
this pull request
Feb 10, 2025
* using sdpa if available * Update model.py
Bretterbear
pushed a commit
to desiredeffect/whisper
that referenced
this pull request
Apr 4, 2025
* using sdpa if available * Update model.py
heejipark23
pushed a commit
to heejipark23/whisper
that referenced
this pull request
Sep 21, 2025
* using sdpa if available * Update model.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.