Repository navigation
Improve diagnostics for report attachment failures - #49852
Merged
copyberry[bot] merged 1 commit intoOct 1, 2026
Merged
copyberry[bot] merged 1 commit into
copyberry[bot] merged 1 commit into
Conversation
## Why Skipped report attachments lacked diagnostic logs, and upload failures logged only the HTTP status. Transport error strings can also contain credential-bearing URLs. ## What changed - Log why attachments are skipped, including missing rollout files, non-regular files, size limits, rate limits, and upload deadlines. - Log attachment failures at error level with the error chain and available HTTP status. - Replace `RouteAwareRequestError` details with the failure class and timeout, connection, request, and body flags before logging, avoiding credential-bearing transport URLs. GitOrigin-RevId: 1bfd1cc74137ea83d05098e9dbf58ed7b62385cc
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/1bfd1cc74137ea83d05098e9dbf58ed7b62385cc
branch
from
October 1, 2026 04:04
2a4c7cd to
236be1a
Compare
Contributor
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/1bfd1cc74137ea83d05098e9dbf58ed7b62385cc
branch
October 1, 2026 04:05
feng-tempo
temporarily deployed
to
issue-triage
October 1, 2026 04:14 — with
GitHub Actions
Inactive
feng-tempo
temporarily deployed
to
issue-triage
October 1, 2026 04:14 — with
GitHub Actions
Inactive
feng-tempo
temporarily deployed
to
issue-triage
October 1, 2026 04:14 — with
GitHub Actions
Inactive
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve diagnostics for report attachment failures
Why
Skipped report attachments lacked diagnostic logs, and upload failures logged only the HTTP status. Transport error strings can also contain credential-bearing URLs.
What changed
RouteAwareRequestErrordetails with the failure class and timeout, connection, request, and body flags before logging, avoiding credential-bearing transport URLs.