Skip to content

Improve diagnostics for report attachment failures - #49852

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/1bfd1cc74137ea83d05098e9dbf58ed7b62385cc
Oct 1, 2026
Merged

copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/1bfd1cc74137ea83d05098e9dbf58ed7b62385cc

Conversation

@copyberry

@copyberry copyberry Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Improve diagnostics for report attachment failures

Why

Skipped report attachments lacked diagnostic logs, and upload failures logged only the HTTP status. Transport error strings can also contain credential-bearing URLs.

What changed

  • Log why attachments are skipped, including missing rollout files, non-regular files, size limits, rate limits, and upload deadlines.
  • Log attachment failures at error level with the error chain and available HTTP status.
  • Replace RouteAwareRequestError details with the failure class and timeout, connection, request, and body flags before logging, avoiding credential-bearing transport URLs.

## Why

Skipped report attachments lacked diagnostic logs, and upload failures logged only the HTTP status. Transport error strings can also contain credential-bearing URLs.

## What changed

- Log why attachments are skipped, including missing rollout files, non-regular files, size limits, rate limits, and upload deadlines.
- Log attachment failures at error level with the error chain and available HTTP status.
- Replace `RouteAwareRequestError` details with the failure class and timeout, connection, request, and body flags before logging, avoiding credential-bearing transport URLs.

GitOrigin-RevId: 1bfd1cc74137ea83d05098e9dbf58ed7b62385cc
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/1bfd1cc74137ea83d05098e9dbf58ed7b62385cc branch from 2a4c7cd to 236be1a Compare October 1, 2026 04:04
@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@copyberry
copyberry Bot merged commit 236be1a into main Oct 1, 2026
1 check failed
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/1bfd1cc74137ea83d05098e9dbf58ed7b62385cc branch October 1, 2026 04:05
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 1, 2026

This branch was previously deployed

1 inactive deployment
issue-triage — 236be1ad Deployed Oct 1, 2026 by feng-tempo via Identify potential duplicates (all issues) #50406
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants