Repository navigation
Share cached exec-server environment info with Arc - #49798
Merged
copyberry[bot] merged 1 commit intoOct 1, 2026
Merged
copyberry[bot] merged 1 commit into
copyberry[bot] merged 1 commit into
Conversation
## What changed Return `Arc<EnvironmentInfo>` from `ExecServerClient::environment_info()` so repeated reads and cloned clients share cached metadata without cloning its contents. Wrap metadata from initialization and lazy RPC fetches in `Arc`, while preserving the owned return value in `LazyRemoteExecServerClient`. ## Testing Extend the cache test to assert pointer identity across cloned clients for both initialization-provided metadata and lazy fetching after connecting to a legacy server. GitOrigin-RevId: 3f56f4d51a4aebc0c4821c0b128a70efb23933d4
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/3f56f4d51a4aebc0c4821c0b128a70efb23933d4
branch
from
October 1, 2026 01:22
26cf2f4 to
c538fba
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/3f56f4d51a4aebc0c4821c0b128a70efb23933d4
branch
October 1, 2026 01:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Share cached exec-server environment info with Arc
What changed
Return
Arc<EnvironmentInfo>fromExecServerClient::environment_info()so repeated reads and cloned clients share cached metadata without cloning its contents. Wrap metadata from initialization and lazy RPC fetches inArc, while preserving the owned return value inLazyRemoteExecServerClient.Testing
Extend the cache test to assert pointer identity across cloned clients for both initialization-provided metadata and lazy fetching after connecting to a legacy server.