Skip to content

Strengthen session file change approval coverage - #36149

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/53a3f746940677043e097094862c28faf4db1a8d
Jul 30, 2026
Merged

copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/53a3f746940677043e097094862c28faf4db1a8d

Conversation

@copyberry

@copyberry copyberry Bot commented Jul 30, 2026 •

Copy link
Copy Markdown

Strengthen session file change approval coverage

Why

The notification helper buffers unrelated server requests, so the session-scoped
file change approval test could overlook an unexpected second approval request.

What changed

  • Consume approval resolution and file change completion events directly and
    verify their request, thread, turn, and item identities.
  • Fail if the second patch requests approval after the first patch was accepted
    for the session.
  • Shut down the app server gracefully and assert that it exits successfully.

## Why

The notification helper buffers unrelated server requests, so the session-scoped
file change approval test could overlook an unexpected second approval request.

## What changed

- Consume approval resolution and file change completion events directly and
  verify their request, thread, turn, and item identities.
- Fail if the second patch requests approval after the first patch was accepted
  for the session.
- Shut down the app server gracefully and assert that it exits successfully.

GitOrigin-RevId: 53a3f746940677043e097094862c28faf4db1a8d
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/53a3f746940677043e097094862c28faf4db1a8d branch from a14c6bc to b545c94 Compare July 30, 2026 12:30
@copyberry
copyberry Bot merged commit b545c94 into main Jul 30, 2026
32 checks passed
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/53a3f746940677043e097094862c28faf4db1a8d branch July 30, 2026 12:31
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 30, 2026
@gerph
gerph temporarily deployed to issue-triage July 30, 2026 12:41 — with GitHub Actions Inactive
@gerph
gerph temporarily deployed to issue-triage July 30, 2026 12:41 — with GitHub Actions Inactive
@gerph
gerph temporarily deployed to issue-triage July 30, 2026 12:41 — with GitHub Actions Inactive

This branch was previously deployed

1 inactive deployment
issue-triage — b545c940 Deployed Jul 30, 2026 by alb3rtushendra-code via Translate non-English issue #6167
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.