Skip to content

Avoid cloning ignored analytics notifications - #36020

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/2fa0711dbdcca33dce82c3ef78ee53a3f5a65bd9
Jul 29, 2026
Merged

copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/2fa0711dbdcca33dce82c3ef78ee53a3f5a65bd9

Conversation

@copyberry

@copyberry copyberry Bot commented Jul 29, 2026 •

Copy link
Copy Markdown

Avoid cloning ignored analytics notifications

What changed

  • Pass server notifications to analytics tracking by reference.
  • Clone only the notification variants that are recorded as analytics facts.

Testing

  • Add unit coverage that verifies a turn diff notification is enqueued and a command output delta notification is ignored.

## What changed

- Pass server notifications to analytics tracking by reference.
- Clone only the notification variants that are recorded as analytics facts.

## Testing

- Add unit coverage that verifies a turn diff notification is enqueued and a command output delta notification is ignored.

GitOrigin-RevId: 2fa0711dbdcca33dce82c3ef78ee53a3f5a65bd9
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/2fa0711dbdcca33dce82c3ef78ee53a3f5a65bd9 branch from 0e89982 to 88d6c2b Compare July 29, 2026 20:09
@copyberry
copyberry Bot merged commit 88d6c2b into main Jul 29, 2026
30 of 32 checks passed
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/2fa0711dbdcca33dce82c3ef78ee53a3f5a65bd9 branch July 29, 2026 20:11
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 29, 2026

This branch was previously deployed

1 inactive deployment
issue-triage — 88d6c2b2 Deployed Jul 29, 2026 by jtsang4 via Identify potential duplicates (open issues fallback) #34946
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants