Repository navigation
Enforce centralized SQLite connection creation - #35828
Merged
copyberry[bot] merged 1 commit intoJul 28, 2026
Merged
copyberry[bot] merged 1 commit into
copyberry[bot] merged 1 commit into
Conversation
## Why Direct SQLx constructors can bypass the shared SQLite configuration in `codex-state`. ## What changed - Deny SQLx pool, connection, and database creation methods through the workspace Clippy configuration for both Cargo and Bazel builds. - Exempt `codex-rs/state/src/sqlite.rs`, the centralized connection shim, from the lint. - Document that the deny list must be audited when upgrading SQLx. GitOrigin-RevId: e20d7e83095727ac446347157782175062a100fc
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/e20d7e83095727ac446347157782175062a100fc
branch
from
July 28, 2026 20:50
11777ca to
50a7328
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/e20d7e83095727ac446347157782175062a100fc
branch
July 28, 2026 20:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enforce centralized SQLite connection creation
Why
Direct SQLx constructors can bypass the shared SQLite configuration in
codex-state.What changed
workspace Clippy configuration for both Cargo and Bazel builds.
codex-rs/state/src/sqlite.rs, the centralized connection shim, fromthe lint.