Repository navigation
Follow Omarchy's split battery percentage rows - #408
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Omarchy replaced its single
trigger.appearance.top-bar.indicators.battery-percentagerow with two rows,appearance.top-bar.indicators.battery-percentage-onand-off. Each checksomarchy-hw-laptopand the current setting. Our change to the old row no longer applied, so the VM lost the battery percentage toggle, andmake test-upstreamfailed onmainand on every PR.|| batteryto the whole condition, as before, would have shown both rows at once.pkgrel30 â 31.Tested
Mac: Apple Silicon, macOS 27.0.1.
make test-upstreamagainst Omarchy 4.0.0.r7217: 16 tests, OK (it failed onmainbefore).make test-guest: 88 tests, OK.make test: passes.Not checked: the menu in a running VM.
make e2ewasn't run; the app, runtime and bridges don't change.One concern
No files owned by Omarchy are edited. If the guest package changed, its
pkgrelis bumpedmake e2epasses, if this changes the app, runtime, launcher or bridges (CI cannot boot the VM)No secrets or personal data in the code, logs or captures