Skip to content

Follow Omarchy's split battery percentage rows - #408

Merged
themartiano merged 1 commit into
mainfrom
follow-omarchy-battery-percentage-row
Oct 22, 2026
Merged

themartiano merged 1 commit into
mainfrom
follow-omarchy-battery-percentage-row

Conversation

@themartiano

@themartiano themartiano commented Oct 22, 2026 •

Copy link
Copy Markdown
Collaborator

What and why

Omarchy replaced its single trigger.appearance.top-bar.indicators.battery-percentage row with two rows, appearance.top-bar.indicators.battery-percentage-on and -off. Each checks omarchy-hw-laptop and the current setting. Our change to the old row no longer applied, so the VM lost the battery percentage toggle, and make test-upstream failed on main and on every PR.

  • The package now widens the laptop check in both new rows to also accept a Mac battery. Appending || battery to the whole condition, as before, would have shown both rows at once.
  • Menu release 8 adds the two rows to existing menus. Rows the user removed stay removed.
  • The old row is no longer written. Menus that already have it keep it. Omarchy no longer has its parent menu, so it doesn't appear there.
  • A new upstream contract fails when one of our changes no longer changes Omarchy's row, for example if the laptop check is reworded.
  • pkgrel 30 → 31.

Tested

Mac: Apple Silicon, macOS 27.0.1.

  • make test-upstream against Omarchy 4.0.0.r7217: 16 tests, OK (it failed on main before).

  • make test-guest: 88 tests, OK.

  • make test: passes.

  • Not checked: the menu in a running VM. make e2e wasn't run; the app, runtime and bridges don't change.

  • One concern

  • No files owned by Omarchy are edited. If the guest package changed, its pkgrel is bumped

  • make e2e passes, if this changes the app, runtime, launcher or bridges (CI cannot boot the VM)

  • No secrets or personal data in the code, logs or captures

@themartiano
themartiano merged commit 0c8df28 into main Oct 22, 2026
7 checks passed
@themartiano
themartiano deleted the follow-omarchy-battery-percentage-row branch October 22, 2026 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant