Repository navigation
Fix flaky runtime capability check - #345
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
The macOS 15 runtime build on PR #337 failed with a broken pipe and incorrectly reported that QEMU lacked ARM virtualization support. The capability probe piped captured help through
grep -q, which can exit after a match beforeprintffinishes;pipefailthen rejects a supported runtime.Check the captured help directly in Bash. Missing capabilities and failed QEMU queries still fail verification. Add regression coverage for large help output, supported and unsupported machines, and query failures to
make test.Testing
python3 macos/Tests/test-runtime-capabilities.py: all four tests pass; the large-output case failed before the fix.make test: passed on Apple Silicon macOS (426 Swift tests and 379 guest tests, plus all contract, shell, and disk resize suites).make runtime: passed the full pinned graphics/QEMU build, relocation, signing, capability verification, and macOS 15.0 compatibility audit.bash -n macos/prepare-qemu-gpu-runtime.shandgit diff --check: passed.CI verification on macOS 15 and 26 is pending.