Repository navigation
fix: configure guest lock screen authentication - #272
Merged
Merged
Conversation
Fail-Safe
marked this pull request as ready for review
September 27, 2026 15:03
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
Fixes #259. The factory bypasses the upstream installer step that creates
/etc/pam.d/omarchy-lock-password. Quickshell therefore answersmissing-pamand refuses to lock;omarchy system lockdiscards that response, making the menu, shortcut, and command appear to do nothing.Run the pinned upstream
omarchy-apply-lockduring factory finalization and require a root-owned, mode-0644 policy before publishing the image. Documentsudo omarchy-apply-lockfor existing guests, which retain their disk when the Mac app updates. This uses the upstream PAM policy and existing guest password.Testing
make test: passed (245 guest tests, 373 Swift tests, shell/integration checks).passwordPam: truewithout a repair command. Command, shortcut, and System menu locking passed; wrong passwords remained locked and the correct password unlocked, including after reboot. Test provisioning used upstream owner-provisioning functions with disposable account values.Adendum: Keybinding
The Omarchy default keybinding for locking the system is SUPER + CTRL + L. For those who want to maintain the default macOS keybinding for system lock, you can drop this into your
~/.config/hypr/bindings.luafile:o.bind("SUPER + CTRL + Q", "Lock system", "omarchy system lock")