Repository navigation
ci: add option for the ci to check locales - #312
Merged
Merged
Conversation
add support for a "dry-run" to "generateLocale.ts" , so that locales get checked in the ci
Totto16
force-pushed
the
add_locales_check_to_ci
branch
from
September 3, 2024 16:52
aca1577 to
2de0699
Compare
oae
approved these changes
Sep 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
add support for a "dry-run" to "generateLocale.ts" , so that locales get checked in the CI
This helps in the case of locale updates, as the CI catches such things as in #305
This was done in a quick fashion and can certainly be improved, I didn't use a cli parser, since this just adds one simple optional option.
Any suggestions for improvements or arguments against this are welcome. ❤️
Type of change
Checklist