Repository navigation
feat: add certStoreManager interface to wrap operations on namespaced certStores [multi-tenancy PR 5] - #1382
Merged
Conversation
binbin-li
requested review from
akashsinghal,
jimmyraywv,
luisdlp,
susanshi and
toddysm
as code owners
April 11, 2024 11:34
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## staging #1382 +/- ##
===========================================
+ Coverage 65.31% 65.52% +0.21%
===========================================
Files 105 109 +4
Lines 5458 5570 +112
===========================================
+ Hits 3565 3650 +85
- Misses 1535 1565 +30
+ Partials 358 355 -3 ☔ View full report in Codecov by Sentry. |
binbin-li
force-pushed
the
multi-tenancy-pr-5
branch
from
April 12, 2024 07:43
b206dc3 to
1904b01
Compare
binbin-li
force-pushed
the
multi-tenancy-pr-5
branch
from
April 12, 2024 13:18
1904b01 to
bedadfa
Compare
binbin-li
force-pushed
the
multi-tenancy-pr-5
branch
2 times, most recently
from
April 15, 2024 02:33
29322ca to
1e62aca
Compare
binbin-li
force-pushed
the
multi-tenancy-pr-5
branch
from
April 15, 2024 03:07
1e62aca to
f3f2d13
Compare
12 tasks
susanshi
reviewed
Apr 17, 2024
binbin-li
force-pushed
the
multi-tenancy-pr-5
branch
from
April 17, 2024 02:47
1d3450e to
b22785c
Compare
susanshi
previously approved these changes
Apr 17, 2024
susanshi
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me. thanks!
susanshi
approved these changes
Apr 17, 2024
binbin-li
enabled auto-merge (squash)
April 17, 2024 06:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What this PR does / why we need it:
This is the 5th PR for multi-tenancy support. Please review #1380 first. Check diff between PR 4 and PR 5 at: binbin-li#120
CertificatesMapunder controllers to resource_map.go so that it can be shared by clustered and namespaced controllers in the future.Note:
The nested certStore map is like:
We keep the namespace prefix for inner map key to faciliate accessing from verifier.
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #
Type of change
Please delete options that are not relevant.
mainbranch)How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
Checklist:
Post Merge Requirements
Helm Chart Change