Skip to content

Fix version number contained in files and Release as v0.6.1 (was: Update Conan recipe for v0.6.0) #47

Closed

Description

@martinmoene

Per PR #46

  • Update Make new GitHub Release tag.
  • Update Conan recipe: Create PR.
  • Update Conan recipe: PR merged.

Activity

  1. striezel commented on Jun 27, 2022

    @striezel
    Contributor

    Update GitHub Release tag

    If that means that the old tag is deleted and another commit is tagged as v0.6.0, then be aware that this may cause some inconsistencies among existing forks and working copies of expected-lite. More details about why re-tagging can be problematic can be read in the official Git documentation: https://git-scm.com/docs/git-tag#_on_re_tagging

    Bottom line is:

    Git does not update tags in existing repositories when doing a git fetch or git pull. So anyone who has checked out the repository will still have the old v0.6.0 tag unless the tag is updated manually in that person's repository checkout. So it might be easier to just create a new tag (e. g. v0.6.1) and use that one instead, possibly pointing out that v0.6.0 has the wrong version in the code and should not be used anymore.

  2. martinmoene commented on Jun 27, 2022

    @martinmoene
    CollaboratorAuthor

    Thanks @striezel for your informed suggestion to do a/the sensible thing :)

  3. changed the title [-]Update Conan recipe for v0.6.0[/-] [+]Fix version number contained in files and Release as v0.6.1 (was: Update Conan recipe for v0.6.0)[/+] on Jun 28, 2022
  4. martinmoene commented on Jun 28, 2022

    @martinmoene
    CollaboratorAuthor

    Released v0.6.1 here and on Conan Center, closing issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions