Repository navigation
fix(oxvg_collections): don't split lists at escaped separators - #298
Merged
Merged
Conversation
`font-family="'Foo, Inc'"` is written as `Foo\, Inc`, which is valid CSS. Parsing that again split the list at the escaped comma, leaving `Foo\` (read as `Foo` + U+FFFD) and `Inc`. `ListOf` now treats a backslash as escaping the next character, both in unquoted items and inside quotes, where an escaped quote no longer ends the item. Closes noahbald#297 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
font-family="'Foo, Inc'"is written asFoo\, Inc, which is valid CSS, but a second pass split it at the escaped comma intoFoo\(read asFoo+ U+FFFD) andInc.ListOfnow treats a backslash as escaping the next character, in unquoted items and inside quotes (so'Foo\', Inc'is one family too).Closes #297
How Has This Been Tested?
Extended the
font_familyunit test with a round trip; it fails without the fix. All crate tests pass. Two passes over'Foo, Inc',Foo\, Inc,Foo\2c Inc,a\\, band'Foo\', Inc'are now stable. On 157 real-world SVGs the output is identical to main with thenone,safeanddefaultpresets.Types of changes
Fixes
Checklist:
🤖 Generated with Claude Code