Repository navigation
Add support for XOAUTH2 - #6819
Merged
Merged
Conversation
This was referenced Jul 1, 2022
miaulalala
reviewed
Jul 1, 2022
ChristophWurst
commented
Jul 1, 2022
This comment was marked as resolved.
This comment was marked as resolved.
ChristophWurst
marked this pull request as ready for review
July 1, 2022 13:55
miaulalala
approved these changes
Jul 1, 2022
miaulalala
left a comment
miaulalala
left a comment
Contributor
There was a problem hiding this comment.
LGTM! This is just for occ at the moment, right?
miaulalala
reviewed
Jul 1, 2022
Member
Author
Yes! #6819 (comment) |
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
force-pushed
the
enhancement/xoauth2-support
branch
from
July 1, 2022 14:09
4892836 to
7870487
Compare
ChristophWurst
enabled auto-merge
July 1, 2022 14:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the foundation for #6454 and #6591.
You can now add an account via CLI if you know the OAUTH access token. Horde will successfully authenticate using the token.
The process of acquiring the token will be specific to each service. We will have to implement those parts for Google and Microsoft.