Repository navigation
OSC playlist randomly changes size when clicking 'pl prev'/'pl next' buttons in OSC with '--force-window=yes'Â #4081
Description
Hello.
mpv version and platform
Reproducible with mpv-0.2{1,2,3}.0 or mpv-git @ 9c90c90 on Gentoo amd64.
Reproduction steps
- Open playlist with several files and make sure the video window is opened.
- Click 'pl prev'/'pl next' buttons in OSC in the video window.
Expected behavior
Playback switches to the previous/next file and the displayed OSD has normal size.
Actual behavior
Playback switches to the previous/next file and the displayed OSD changes size from normal to huge at random.
Log file
mpv 0.23.0 logfile: http://sprunge.us/RiHS
mpv-git logile: http://sprunge.us/XKAZ
ffmpeg -f x11grab output: https://0x0.st/VoU.mp4
Please fix.
Activity
[-]OSD randomly changes size when clicking 'pl prev'/'pl next' buttons in OSC[/-][+]OSD randomly changes size when clicking 'pl prev'/'pl next' buttons in OSC with '--force-window=yes'[/+]Coacher commentedon Jan 28, 2017
Not reproducible when there is actual video.
mc4man commentedon Jan 29, 2017
If scalefullscreen= & scaleforcedwindow= are the same value then you'd likely get consistent results, after that the results could be quite unexpected.
i'd think typically users would have scalefullscreen a lower value than scaleforcedwindow which produces poor results at times depending on values used.
The most unexpected is a high scalefullscreen with a low scaleforcedwindow which makes the playlist smaller the higher scalefullscreen goes and or the lower scaleforcedwindow goes.
Can't see why for audio only thru the pseudo-gui one would want to go fullscreen..
Coacher commentedon Jan 29, 2017
@mc4man, this issue isn't about consistency, but about weird scaling glitches. See demo video in OP.
mc4man commentedon Jan 30, 2017
Coacher commentedon Jan 31, 2017
@mc4man, I misunderstood your first comment.
Indeed, if I set
scalewindowed,scalefullscreen,scaleforcedwindowto 1, then these glitches no longer happen. Default values cause these glitches though.It would be nice to have non-problematic default values or fix the underlying bug.
[-]OSD randomly changes size when clicking 'pl prev'/'pl next' buttons in OSC with '--force-window=yes'[/-][+]OSC playlist randomly changes size when clicking 'pl prev'/'pl next' buttons in OSC with '--force-window=yes'[/+]osc: refactor osc message scaling
osc: refactor osc message scaling
osc: refactor osc message scaling
osc: refactor osc message scaling
osc: refactor osc message scaling