Window dragging doesn’t work on OS X until the OSC has been activated at least once

Window dragging from anywhere (i.e. by dragging the video being displayed as opposed to the top bar) does not work on OS X if the on-screen display hasn’t been available at least once.

So if for example the showwindowed=no option is set and we open a video in windowed mode, window dragging will be unavailable until the video is made fullscreen at least once. By this I mean that when opening the video it won’t work at all, but if we quickly go in and out of fullscreen, then it starts working for the duration of the video.

Reproducible both with --script-opts=osc-showwindowed=no and in ~/.mpv/lua-settings/osc.conf.

If we completely disable the on-screen display in both cases (--script-opts=osc-showwindowed=no,osc-showfullscreen=no, or by setting both options in ~/.mpv/lua-settings/osc.conf), then window dragging won’t work at all.

Currently on mpv version 0.9.2, installed via homebrew with no specified flags, from the official repo. OS X Yosemite 10.10.3.

Could you test with HEAD? Dragging works for me (always did). Probably try with --no-config too and try to identify the problematic option in case it works.

Same here, works perfectly (tried with my config and with --no-config)

Same, it works as expected here (10.10.3, HEAD mpv).

Found the culprit: it’s the showwindowed=no option. Reproducible both with --script-opts=showwindowed=no and in ~/.mpv/lua-settings/osc.conf.

You are right, I can reproduce it as well.

Still happens in 0.9.0. Updated top comment to reflect that.

There’s a really ugly hack to work around this. Simply execute the following line.

mkdir -p "${HOME}/.mpv/scripts && echo 'function cycle_fullscreen()\n  mp.command("cycle fullscreen")\nend\n\nmp.register_event("start-file", cycle_fullscreen)\nmp.register_event("file-loaded", cycle_fullscreen)' > "${HOME}/.mpv/scripts/cycle_fullscreen_twice.lua"

What it does is create a .mpv/scripts directory, if it didn’t exist, in your home. It then creates a cycle_fullscreen_twice.lua file inside it with the contents

function cycle_fullscreen()
  mp.command("cycle fullscreen")
end

mp.register_event("start-file", cycle_fullscreen)
mp.register_event("file-loaded", cycle_fullscreen)

which basically just makes mpv toggle fullscreen twice when opening a file.

Actually, scratch that, as it causes other problems and may even hang mpv.

@wm4

@wm4 Should be --script-opts=osc-showwindowed=no instead. The osc- prefix was left out before (not sure if I just forgot to write it or if the requirement came after the issue was opened).

@wm4

@wm4 Actually, looking further into it, it appears the issue can be more accurately described as “window dragging doesn’t work on OS X until the OSC has been activated at least once”. I’ve updated the title and top post to reflect that.

i investigated the issue and the problem is that the function mp_input_test_dragging used in recalcMovableByWindowBackground always returns true, when used with --script-opts=osc-showwindowed=no. it should return false in that case. there seems to be a mouse area active in the OSC which leads to this problem. when cycling the visibility options of the OSC (O script_message osc-visibility cycle) to 'never' an area seem to be properly set and the function returns the right value as expected.

so this isn't an OSX bug per se.

osc: fix window dragging with showwindowed=no

Navigation Menu

Repository navigation

Window dragging doesn’t work on OS X until the OSC has been activated at least once #1819

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Window dragging doesn’t work on OS X until the OSC has been activated at least once #1819

Description

Activity

Argon- commented on Apr 14, 2015

Nyx0uf commented on Apr 14, 2015

ArPrt93 commented on Apr 14, 2015

vitorgalvao commented on Apr 14, 2015

Argon- commented on Apr 14, 2015

vitorgalvao commented on Apr 29, 2015

vitorgalvao commented on Jun 2, 2015

vitorgalvao commented on Jun 3, 2015

vitorgalvao commented on Jun 3, 2015

vitorgalvao commented on Jun 3, 2015

Akemi commented on Dec 12, 2016

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions