Skip to content

Use all remote repositories for artifacts resolving - #226

Merged
slawekjaranowski merged 1 commit into
masterfrom
fix-225
Jul 21, 2022
Merged

slawekjaranowski merged 1 commit into
masterfrom
fix-225

Conversation

@slawekjaranowski

Copy link
Copy Markdown
Member

we should use default remote repositories and repositories defined in project

Fix #225

@slawekjaranowski slawekjaranowski added the bug Something isn't working label Jul 20, 2022

@MarkEWaite MarkEWaite left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jglick

jglick commented Jul 21, 2022

Copy link
Copy Markdown
Contributor

Did either of those approving verify that this change does in fact solve the reported problem? (Did not occur in my configuration to begin with.)

@basil

basil commented Jul 21, 2022

Copy link
Copy Markdown

Did either of those approving verify that this change does in fact solve the reported problem? (Did not occur in my configuration to begin with.)

You must not trust me.

we should use default remote repositories and repositories defined in project

Fix #225
@MarkEWaite

Copy link
Copy Markdown

Did either of those approving verify that this change does in fact solve the reported problem? (Did not occur in my configuration to begin with.)

I did not. I'm happy to attempt that verification if it helps. As far as I can tell, the duplication instructions in the issue report should be repeatable. They are:

$ rm -rf implied-labels-plugin
$ git clone https://github.com/jenkinsci/implied-labels-plugin.git
$ cd implied-labels-plugin
$ echo '<settings></settings>' > settings.xml
$ mvn validate

@slawekjaranowski

Copy link
Copy Markdown
Member Author

I have tested my change with implied-labels-plugin project according to instructions from issue.

I override version for test in pom, like:

  <build>
    <plugins>
        <plugin>
          <artifactId>maven-enforcer-plugin</artifactId>
          <dependencies>
            <dependency>
              <groupId>org.codehaus.mojo</groupId>
              <artifactId>extra-enforcer-rules</artifactId>
              <version>1.6.1-SNAPSHOT</version>
            </dependency>
          </dependencies>
        </plugin>
      </plugins>
  </build>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1.6.0 warns about missing dependencies when previous versions did not

4 participants