Repository navigation
mcp: do not ApplyDefault when res.Content==nil - #1069
Merged
Merged
Conversation
nahapetyan-serob
approved these changes
Jul 10, 2026
This was referenced Oct 4, 2026
guglielmo-san
pushed a commit
that referenced
this pull request
Oct 5, 2026
A `tools/call` request with `"arguments": null` for a tool whose input schema declares a default panics the server with `assignment to entry in nil map`. Unmarshaling `null` into the map in `applySchema` leaves it nil, and `ApplyDefaults` then writes into it. This treats null arguments like missing ones, so the defaults are applied and the call proceeds. The elicitation paths already skip `ApplyDefaults` on a nil `Content` (#1069), so `applySchema` is the only place that needed the check. The two new `TestApplySchema` cases panic on `main`. Fixes #1340
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1062