[crazy-max]

Updates from github.com/urfave/cli v1.22.17 to github.com/urfave/cli/v3 v3.9.0.

The CLI entry points now use v3 *cli.Command APIs, v3 callback signatures, explicit flag aliases, and v3 environment variable sources. The slice flag comma splitting was disabled to preserve existing BuildKit flag behavior.

The v3 module uses a different import path and API shape, so the command setup, action hooks, before and after hooks, and tests needed to move off the removed v1 App and Context types. The migration keeps the existing command behavior while updating the dependency.

[tonistiigi]

My agents found this:

buildctl --generate-bash-completion regressed. v1 exposed this via EnableBashCompletion; after switching to v3, only --generate-shell-completion works. I verified go run ./cmd/buildctl --generate-bash-completion now fails with flag provided but not defined. If external completion scripts or users rely on the old flag, this is a CLI compatibility break. Either preserve the old hidden flag/alias or call it out intentionally.

I think this is fine though as buildctl is a dev CLI. Possibly this can be somehow patched from our side but not sure if even needed. Just calling it out in the changelog should be enough.

[crazy-max]

My agents found this:

buildctl --generate-bash-completion regressed. v1 exposed this via EnableBashCompletion; after switching to v3, only --generate-shell-completion works. I verified go run ./cmd/buildctl --generate-bash-completion now fails with flag provided but not defined. If external completion scripts or users rely on the old flag, this is a CLI compatibility break. Either preserve the old hidden flag/alias or call it out intentionally.

I think this is fine though as buildctl is a dev CLI. Possibly this can be somehow patched from our side but not sure if even needed. Just calling it out in the changelog should be enough.

Yeah I don't think we need to carry a local compatibility shim for the old hidden --generate-bash-completion flag for such CLI.