Repository navigation
test: stabilize worker exec pid1 lifetime - #6810
Merged
Merged
Conversation
github-actions
Bot
added
area/worker
area/testing
area/client
area/executor
and removed
area/testing
labels
Member
Author
|
The second commit is actual bugfix that was exposed by the modified test. |
crazy-max
approved these changes
Jun 9, 2026
crazy-max
left a comment
crazy-max
left a comment
Member
There was a problem hiding this comment.
Needs rebase otherwise LGTM
Drive the background pid1 process with stdin so the test controls its lifetime explicitly. Add a bounded wait after closing stdin to avoid hanging if executor cleanup regresses. Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Delay containerd stdin CloseIO until BuildKit's stdin reader reaches EOF. This avoids racing the shim FIFO copy path, where closing stdin before the copy completes can leave execs stuck or missing stdin data. Add a client gateway regression that runs concurrent execs writing stdin into files and verifies every payload is present. Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
tonistiigi
force-pushed
the
containerd-exec-test-fix
branch
from
June 10, 2026 00:29
cc9567d to
cb6df1c
Compare
This was referenced Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drive the background pid1 process with stdin so the test controls its lifetime explicitly. Add a bounded wait after closing stdin to avoid hanging if executor cleanup regresses.
Flaky test fix for: