Repository navigation
resolver: allow anonymous auth while preserving local image fallback - #6760
Merged
Merged
Conversation
crazy-max
marked this pull request as ready for review
May 8, 2026 11:54
crazy-max
force-pushed
the
session-empty-fallback
branch
from
May 8, 2026 13:00
329cf72 to
1795e48
Compare
crazy-max
force-pushed
the
session-empty-fallback
branch
from
May 29, 2026 13:48
1795e48 to
dc48530
Compare
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
session-empty-fallback
branch
2 times, most recently
from
May 29, 2026 14:47
644c28c to
13596a2
Compare
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
session-empty-fallback
branch
from
May 29, 2026 15:17
13596a2 to
ca9bcf0
Compare
tonistiigi
approved these changes
Jun 3, 2026
zgeoff
added a commit
to zgeoff/impz
that referenced
this pull request
Oct 3, 2026
Engines before Docker 29.6.0 (BuildKit v0.31.0, moby/buildkit#6760) fetch the BUILDKIT_SYNTAX frontend only through a client session, which impd's sessionless build lacks, so every build failed on Docker 28. impd now inspects the frontend before the build and pulls it by digest when the engine lacks it; a failed pull fails the build with a 502.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR restores anonymous Bearer token resolution from #6744 when no client session is active and preserves BuildKit's existing default-mode local fallback behavior.
The important clarification from the follow-up discussion is that BuildKit
ResolveModeDefaultis still remote-first. In v0.29, default mode only used the local image store opportunistically when remoteResolve()failed, and it returned the original remote error if local lookup also failed:buildkit/util/resolver/pool.go
Lines 250 to 262 in 8543ce4
The regression from anonymous auth is that remote
Resolve()can now succeed without a session, then fail later during image config or platform selection. This PR applies the same opportunistic local fallback at that later failure point, without changingpullmode or making BuildKit default mode prefer local.This is separate from Moby's Docker build semantics. Moby currently maps
PullParent=falseto BuildKitimage-resolve-mode=defaultandPullParent=truetopull: https://github.com/moby/moby/blob/675945d39e1b4dc0e5806b216191e29094e43ec1/daemon/internal/builder-next/builder.go#L350-L354. If Moby wants stronger legacy builder "local parent wins" behavior, that should be handled explicitly in Moby by choosing the appropriate resolve mode, not by changing BuildKit default mode here.