Repository navigation
Add missing <algorithm> include to buffer_cache.h - #3053
Merged
awni merged 1 commit intoJan 23, 2026
Merged
Conversation
Fixes compilation with GCC 15+ which doesn't transitively include <algorithm> through <functional> or <map>. Fixes ml-explore#3051.
Anri-Lombard
force-pushed
the
fix/buffer-cache-missing-include
branch
from
January 23, 2026 17:21
d90fe18 to
286d2a7
Compare
angeloskath
approved these changes
Jan 23, 2026
angeloskath
left a comment
angeloskath
left a comment
Member
There was a problem hiding this comment.
Thanks!
You can see the discussion regarding IWYU at #3000 ...
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fixes #3051.
buffer_cache.husesstd::find_ifbut doesn't include<algorithm>. This works with Clang (which transitively includes it through<functional>or<map>), but fails with GCC 15+.@awni would something like https://github.com/include-what-you-use/include-what-you-use be useful to catch these? Or is it too noisy for this codebase?
Checklist
pre-commit run --all-filesto format my code / installed pre-commit prior to committing changes