Skip to content

v1.05 release candidate (betatest) #341

Closed

Description

@coderofsalvation

HELP wanted: I'd like to kindly ask anyone to test the current v1.05 branch (here be dragons).

Various exciting reviewed PR's have been merged into the rc/1.05 branch:

image

builds

  • ubuntu/appimage: coming soon (please build yourself or ask for it via comments to this issue)
  • win64 build
  • win32 build
  • nix
  • MAC: see below

MAC devs: As I don't have a mac, I would be SO THANKFUL if somebody could build rc/1.05 and give it a go?
@johngirvin @ghost @krehel @wormyrocks

TESTCASES

please help test the following for the next release:

  1. does the new build work well with the existing milkytracker config file (in user configuration/home dir).
  2. if not, does it work when temporarely moving the milkytracker config file to another file (a new one will be created).
  3. does ticking classic UX-checkbox and unticking flat button (see config>layout) revert to the classic (cluttered) UI (after restarting?)
  4. does the SYNTH work (sampler section)
  5. does the SYNTH rename the current sample to an ASCIISYNTH string?
  6. does the synth allow painting over the current wave (additional synthesis)
  7. do the new effects work (sampler section and limiter in global section)
  8. does the sampler section gets updated with the current sampler when selecting a different instrument note in the pattern editor (instr. backtrace needs to be enabled in global settings)
  9. are the dialogs now styled with the same background colors as the palette (used to be statically defined to light-gray)
  10. other thoughts?

After fixing the last bugs of rc/1.05 we can: safely merge to master, and do a release v1.05 !
Sorry for the long wait, but this workflow is a safer way, as many reviewed PR's were interdependent.

The PR's (#291) and (#282) will probably be pushed towards v1.06 as they might get refactored to lua (which ties in with more recent discussions here)

Activity

  1. changed the title [-]exciting v1.05 release candidate (betatest)[/-] [+]v1.05 release candidate (betatest)[/+] on Apr 3, 2024
  2. johngirvin commented on Apr 3, 2024

    @johngirvin

    Line 94 of TrackerStartUp.cpp needs to be getenv("NO_SCALE") instead of std::getenv("NO_SCALE") to build on my macOS 12 box. It starts OK and plays a mod but I'm not really able to test it further.

  3. Deltafire commented on Apr 3, 2024

    @Deltafire
    Member

    Line 94 of TrackerStartUp.cpp needs to be getenv("NO_SCALE") instead of std::getenv("NO_SCALE") to build on my macOS 12 box. It starts OK and plays a mod but I'm not really able to test it further.

    AppVeyor reported this problem with Visual Studio 2017 also:

    https://ci.appveyor.com/project/Deltafire/milkytracker/builds/49486977

  4. Deltafire commented on Apr 3, 2024

    @Deltafire
    Member

    MacOS test build:
    milkytracker-1.05.RC-Darwin.dmg.zip
    (scroll the finder window to the right to show the MilkyTracker icon)

    Some intial thoughts, testing on MacOS:

    • Wow, the interface has changed! Not sure how I would now do the things that the buttons are now missing for. I found the 'Classic UX' button in settings.
    • Not sure about the yellow buttons and pink numbers.
    • "welcome 2 Milkytracker", I think "Welcome to MilkyTracker" would look better.
    • CTRL seems to be CMD instead, but CMD-h and CMD-space are intercepted by the OS for other functions.
    • The record ❤️ button seems to be stuck down.
    • Opening a file asks if I want to save changes, even if there were none.
  5. coderofsalvation commented on Apr 4, 2024

    @coderofsalvation
    ContributorAuthor

    Line 94 of TrackerStartUp.cpp needs to be getenv("NO_SCALE") instead of std::getenv("NO_SCALE") to build on my

    @Deltafire @johngirvin is fixed now in rc/1.05

    * Wow, the interface has changed! Not sure how I would now do the things that the buttons are now missing for. I found the 'Classic UX' button in settings.
    

    All non-critical buttons are moved to the context-menu (rightclick in pattern editor)

    * Not sure about the yellow buttons and pink numbers.
    

    I think these are your old milkytracker config values leaking into the new default ones.

    * "welcome 2 Milkytracker", I think "Welcome to MilkyTracker" would look better.
    

    OK will change if this fits characterwise.

    * CTRL seems to be CMD instead, but CMD-h and CMD-space are intercepted by the OS for other functions.
    * The record ❤️ button seems to be stuck down.
    * Opening a file asks if I want to save changes, even if there were none.
    

    will investigate thx!

    btw. @Deltafire thank you VERY much for testing, really appreciate it.

  6. Deltafire commented on Apr 4, 2024

    @Deltafire
    Member

    Regarding CMD, I think the solution would be to allow both modifiers - I'll have a look later to see if this can be done.

    Implemented in d3259da

    The MacOS build is a bit broken at the moment, due to a Python2 dependency in the Docerator program it's using to generate doc icons. I think I'll remove this since Docerator has been unmaintained for 10 years now.

    Docerator removed in fd29dae

  7. catbusconductor commented on Apr 5, 2024

    @catbusconductor

    Really cool to see the progress being made here, and the first steps of a GUI overhaul, which I think Milky could really benefit from. I am happy to help testing on Mac if needed, Deltafire's build seems to work OK so far. The testcases all look OK to me though the synth still has some wonky UI handling or maybe I am not using it right (e.g. when changing the paint type, the UI window is redrawn empty and only comes back after clicking one more time)

    Cant wait to see more happening here!

  8. MetalMaxMX commented on Apr 6, 2024

    @MetalMaxMX

    Trying out different resolutions to check how the screen looks and something looked a bit off to me. On the new UI, anything lower than 1024*768 will look off, more specifically, it won't apply any form of bilineal filtering over the UI. I checked the tickbox to make it look back to the old UI and then another regression happened, the same resolution seen from two MilkyTrackers will show off that difference in the lack of filtering. I am wondering if this is a config issue or something else.

  9. coderofsalvation commented on Apr 6, 2024

    @coderofsalvation
    ContributorAuthor

    @MetalMaxMX I'm thinking two things:

    1. does this also happend with a fresh milktracker config? (testcase 2)
    2. Perhaps this is because of: 4ea3dd0

    Btw. which platform, and are you on a high-dpi or non-highdpi screen?
    The idea behind 2 to do scaling similar to schismtracker.
    People had been complaining about the blurryness of milkytracker when scaling up the window.

  10. krehel commented on Apr 6, 2024

    @krehel

    Test build from me - this is a Universal app supporting Apple Silicon and Intel.
    milkytracker-1.04.00-Darwin-universal.dmg.zip

  11. MetalMaxMX commented on Apr 6, 2024

    @MetalMaxMX

    @MetalMaxMX I'm thinking two things:

    1. does this also happend with a fresh milktracker config? (testcase 2)
    
    2. Perhaps this is because of: [4ea3dd0](https://github.com/milkytracker/MilkyTracker/commit/4ea3dd0cdc9a38138acc174ec8ed86cd27b12e1d)
    

    Btw. which platform, and are you on a high-dpi or non-highdpi screen? The idea behind 2 to do scaling similar to schismtracker. People had been complaining about the blurryness of milkytracker when scaling up the window.

    Hello! I am using Linux, Debian 11 more specifically and I built the source code myself. I am under X.org using Xfce with compositing disabled. And I am on a non-highdpi screen, the config 1.05 is using seems to be the same as the one that 1.04 already uses.

    I tried with a new fresh configuration and I didn't have the issue! I then tried a 720*480 resolution with 1x scale and the UI looked a bit jagged, just like when I was trying it. Seems like it lacks some sort of bilinear filter over this mode?

  12. coderofsalvation commented on Apr 11, 2024

    @coderofsalvation
    ContributorAuthor

    @MetalMaxMX interesting, maybe post a screenshot?
    With the settings you mentioned (and all resolutions) it looks OK here, worstcase when resizing the window it can looked jagged for certain dimensions.

    I run xfce too with compositing disabled, so perhaps somehow it got resized on your side anyways?

  13. MetalMaxMX commented on Apr 11, 2024

    @MetalMaxMX

    @coderofsalvation Sure, here's a few

    MilkyTracker New (1.05RC)
    milkytrackernew

    MilkyTracker Old (1.04)
    milkytrackerold

    May be difficult to see but notice that bilinear filtering has been applied on MilkyTracker old (that means 1.04) while 1.05rc doesn't produce any filtering, this is with either the classic UI or not.

  14. Deltafire commented on Apr 12, 2024

    @Deltafire
    Member

    Maybe add a configuration option for 4ea3dd0.

  15. coderofsalvation commented on Apr 12, 2024

    @coderofsalvation
    ContributorAuthor

    @Deltafire good point, I'll add something like this then:

    image

    or worstcase an environment-variable (SCALING=nearest milkytracker) because the config might not be accessible yet during SDL init.

  16. 22 remaining items

  17. elfakyn commented on Dec 5, 2024

    @elfakyn

    This newest one works for me properly on Sequoia 15.1.1. I'm surprised there are backwards compatibility issues with my build. Out of curiosity, what version of XCode did you build it with?

  18. lmnoop commented on Dec 6, 2024

    @lmnoop
    Contributor

    The platform selection screen says Version 15.2 (15C500b) targeting macOS 14.2, which seems weird to me because the system itself is 13.7.1.

  19. boonier commented on Dec 9, 2024

    @boonier

    @lmnoop with your latest build above - I'm on Ventura 13.6.3 and getting what looks like an unsupported architecture, or, something like when the OS is not supported.

    image

    image

    Maybe I'll try just building it myself?

  20. lmnoop commented on Dec 9, 2024

    @lmnoop
    Contributor

    That's the exact thing I got with @elfakyn's build but with her instructions, building my own was a breeze.

  21. boonier commented on Dec 9, 2024

    @boonier

    Actually I just updated to 13.7.1 as I didn't realise that I was behind

    The app loads now! Weird that it's that specific a build though

  22. elfakyn commented on Dec 9, 2024

    @elfakyn

    Here's a build that "should" work on old Mac OS versions, as well as current versions.

    milkytracker-1.05.01-Universal-MacOS10.6.dmg.zip

    I looked into it and you can set a deployment target. I experimented and 10.6 is the earliest it compiles on (older versions give the error c++: error: -fobjc-arc is not supported on versions of OS X prior to 10.6). This also doesn't compile for 32 bit because of -fobjc-arc either, but those machines are ancient by now.

    build_mac.sh

    #!/usr/bin/env bash
    # MacOS universal build
    # https://github.com/milkytracker/MilkyTracker/issues/341#issuecomment-2527798897
    cmake -E make_directory build
    pushd build
    cmake -DCMAKE_BUILD_TYPE=Release -DCMAKE_OSX_ARCHITECTURES="arm64;x86_64" -DCPACK_SYSTEM_NAME="Universal" -DCMAKE_OSX_DEPLOYMENT_TARGET="10.6" ..
    cmake --build . --config Release
    codesign --force --deep --sign - src/tracker/MilkyTracker.app
    cpack .
    popd

    If someone can try the binary I've attached, that would be appreciated. In particular:

    • Does it work on older mac versions?
    • Does it still work on both arm and intel?
    • Does it have any weird bugs on older mac?

    If this works properly, I can open a pull request to add the build script for mac.

  23. coderofsalvation commented on Dec 9, 2024

    @coderofsalvation
    ContributorAuthor

    Thanks for the efforts so far ❤

    btw. not sure how easy it is, but some users have asked 10.5 builds [including myself, I have an old macmini with OSX 10.5.8], so if it's as easy as changing "10.6" to "10.5" please do]

  24. elfakyn commented on Dec 9, 2024

    @elfakyn

    Happy to help!

    Unfortunately no, there are compilation errors on 10.5 and lower because of -fobjc-arc (automatic reference counting).

    ~/repos/MilkyTracker/build ~/repos/MilkyTracker
    -- Enabled MIDI support (Core MIDI)
    LHA decompressor disabled (lhasa unavailable)
    -- Enabled GZIP decompressor
    ZIP decompressor disabled (zziplib unavailable)
    -- Enabled Core Audio support
    -- Configuring done (0.1s)
    -- Generating done (0.1s)
    -- Build files have been written to: /Users/elfakyn/repos/MilkyTracker/build
    [  1%] Building CXX object src/midi/CMakeFiles/midi.dir/osx/MidiReceiver_CoreMIDI.mm.o
    c++: error: -fobjc-arc is not supported on versions of OS X prior to 10.6
    make[2]: *** [src/midi/CMakeFiles/midi.dir/osx/MidiReceiver_CoreMIDI.mm.o] Error 1
    make[1]: *** [src/midi/CMakeFiles/midi.dir/all] Error 2
    make: *** [all] Error 2
    src/tracker/MilkyTracker.app: replacing existing signature
    CPack: Create package using DragNDrop
    CPack: Install projects
    CPack: - Run preinstall target for: MilkyTracker
    CPack Error: Problem running install command: /opt/homebrew/bin/cmake --build . --target "preinstall"
    Please check /Users/elfakyn/repos/MilkyTracker/build/_CPack_Packages/Universal/DragNDrop/PreinstallOutput.log for errors
    CPack Error: Error when generating package: milkytracker
    ~/repos/MilkyTracker
    

    I tried disabling it (which could itself cause problems) but it's encountering other errors which are beyond my mac knowledge...

    [100%] Linking CXX executable MilkyTracker.app/Contents/MacOS/MilkyTracker
    ld: warning: ignoring duplicate libraries: '../ppui/osinterface/libosinterface.a'
    ld: warning: support for macOS with 10.5 minimum deployment target is deprecated and will be removed in a future release
    0  0x104b6fee4  __assert_rtn + 160
    1  0x104b7041c  mach_o::relocatable::CFISection<arm>::addCiePersonalityFixups(mach_o::relocatable::Parser<arm>&, libunwind::CFI_Atom_Info<mach_o::relocatable::CFISection<arm>::OAS> const*) (.cold.1) + 0
    2  0x104ad60ac  ld::passes::stubs::x86_64::classic::StubHelperAtom::copyRawContent(unsigned char*) const + 0
    3  0x104ad38c8  ld::passes::stubs::Pass::makeStub(ld::Atom const&, bool) + 4744
    4  0x104ad4b50  ld::passes::stubs::Pass::process(ld::Internal&) + 1500
    5  0x104ad50ac  ld::passes::stubs::doPass(Options const&, ld::Internal&) + 100
    6  0x1049a88e0  main + 664
    A linker snapshot was created at:
            /tmp/AnimatedFXControl-x86_64.out-2024-12-09-131911.ld-snapshot
    ld: Assertion failed: (targetAtom != NULL), function Fixup, file ld.hpp, line 1094.
    c++: error: linker command failed with exit code 1 (use -v to see invocation)
    make[2]: *** [src/tracker/MilkyTracker.app/Contents/MacOS/MilkyTracker] Error 1
    make[1]: *** [src/tracker/CMakeFiles/tracker.dir/all] Error 2
    make: *** [all] Error 2
    

    A 10.5 build doesn't seem immediately trivial to me, but maybe there's a quick fix from someone who knows the code.

  25. Deltafire commented on Dec 9, 2024

    @Deltafire
    Member

    Quick test on Linux/Wayland. Seems to work okay until I drag the window to a second screen, which causes the GUI to freeze. No error messages and the song keeps playing. Tried with the OpenGL render and also with it disabled using NO_OPENGL=1.

    Also regarding usability; I expected that double clicking on a file to load it would also bring me back to the main menu, instead of having to click Exit. Seems a bit strange that it doesn't, but I can also see a benefit of it being the way it is.

  26. coderofsalvation commented on Jan 28, 2025

    @coderofsalvation
    ContributorAuthor

    closing this: btw thanks all of you for contributing to the wonderful new 1.05 release (see milkytracker.org)

  27. mrpapersonic commented on Jan 15, 2026

    @mrpapersonic

    "better late than never", Mac build of v1.05.01 targeting 10.11 and above: milkytracker-1.05.00-Darwin.dmg.zip

    I also had to apply this patch before it would build: fix-build-elcrapitan.patch

    It seems to work fine here on 10.15.

  28. menor commented on Jan 16, 2026

    @menor

    I have managed to build 1.06 for Intel Mac, it's not a dmg but an executable, is this something that could be useful for anyone? I am sorry but I don't really know what I am doing, but the compiled version seems to run well at least on my computer

  29. pajzd commented on Mar 3, 2026

    @pajzd

    => hello there ! this worked for me, fantastic
    but then i saw the even more tempting & exotic MilkytrackerX ???? wtf ! !??

    with entre autres CSound integration & Soundgrain integration ???!!!! that is heaven ... but unfortunately no mac compilation ...
    please could you , would you compile a version for 10.6 & above , i'm on mac os 10.14.6, not sure if I could compile it ...
    what mac os were you on , to compile yr 10.6 version of Milkytracker ...

    thnx in advance !

    Here's a build that "should" work on old Mac OS versions, as well as current versions.

    milkytracker-1.05.01-Universal-MacOS10.6.dmg.zip

    I looked into it and you can set a deployment target. I experimented and 10.6 is the earliest it compiles on (older versions give the error c++: error: -fobjc-arc is not supported on versions of OS X prior to 10.6). This also doesn't compile for 32 bit because of -fobjc-arc either, but those machines are ancient by now.

    build_mac.sh

    #!/usr/bin/env bash

    MacOS universal build

    #341 (comment)

    cmake -E make_directory build
    pushd build
    cmake -DCMAKE_BUILD_TYPE=Release -DCMAKE_OSX_ARCHITECTURES="arm64;x86_64" -DCPACK_SYSTEM_NAME="Universal" -DCMAKE_OSX_DEPLOYMENT_TARGET="10.6" ..
    cmake --build . --config Release
    codesign --force --deep --sign - src/tracker/MilkyTracker.app
    cpack .
    popd

    If someone can try the binary I've attached, that would be appreciated. In particular:

    * Does it work on older mac versions?
    
    * Does it still work on both arm and intel?
    
    * Does it have any weird bugs on older mac?
    

    If this works properly, I can open a pull request to add the build script for mac.

    => hello there ! this worked for me, fantastic
    but then i saw the even more tempting & exotic MilkytrackerX ???? wtf ! !??

    with entre autres CSound integration & Soundgrain integration ???!!!! that is heaven ...
    please could you compile a version for 10.6 & above , i'm on mac os 10.14.6, not sure if I could compile it ...
    what mac os were you on , to compile yr 10.6 version of Milkytracker ...

    thnx in advance !

  30. coderofsalvation commented on Mar 7, 2026

    @coderofsalvation
    ContributorAuthor

    oh nice!
    @menor could you maybe add .png to the filename, and dragdrop the file to #383 ?

    @pajzd milkytrackerX is legacy since all the good stuff has been merged upstream. Therefore v1.06 is what you want..see the csound integration at the plugin-sections here: #383

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions