Skip to content

Improve column selection by setting origin to clicked position - #66445

Merged
Alexandru Dima (alexdima) merged 1 commit into
microsoft:masterfrom
shreeve:improve-column-selection
Feb 14, 2019
Merged

Alexandru Dima (alexdima) merged 1 commit into
microsoft:masterfrom
shreeve:improve-column-selection

Conversation

@shreeve

@shreeve Steve Shreeve (shreeve) commented Jan 13, 2019 •

Copy link
Copy Markdown
Contributor

In conjunction with setting editor.multiCursorModifier to ctrlCmd, this yields a much more natural alt+click experience. The goofier shift+alt+click that is the default uses the prior cursor position as the start point of the column selection.

See #66444 - Resolve the column selection conversation

@rcdailey

Copy link
Copy Markdown

This won't fix the issue with blank lines though....

@gingerbeardman

Copy link
Copy Markdown

This won't fix the issue with blank lines though....

Robert Dailey (@rcdailey) it's an improvement on than the current behaviour and for that I say: thanks! Steve Shreeve (@shreeve)

@hollowstrawberry

Samuel (hollowstrawberry) commented Jan 13, 2019 •

Copy link
Copy Markdown

You're a godsend. I hope they accept the PR, as it's been long enough (3 years) of unintuitive, non-standard, non-customizable controls for column selection.

@shreeve

Copy link
Copy Markdown
Contributor Author

This won't fix the issue with blank lines though....

Robert Dailey (@rcdailey) - What is the specific issue with the blank lines?

@gingerbeardman

Matt Sephton (gingerbeardman) commented Jan 16, 2019 •

Copy link
Copy Markdown

This won't fix the issue with blank lines though.... ...

Steve Shreeve (@shreeve) the rectangular selection doesn't select past the end of a line, it needs to support "virtual white space" it's not a separate issue but rather just mentioned in the big one about alt-select

@shreeve

Copy link
Copy Markdown
Contributor Author

This is how it's handled in Sublime Text:

sublime-column-selection

Here's how it's handled in VS Code:

vscode-column-selection

@rcdailey

Copy link
Copy Markdown

@shreeve

Copy link
Copy Markdown
Contributor Author

@shreeve

Copy link
Copy Markdown
Contributor Author

In the spirit of clean enhancements to the usability of VS Code, can Isidor Nikolic (@isidorn), JoÃĢo Moreno (@joaomoreno), and Benjamin Pasero (@bpasero) take a look at this PR?

It resolves a long standing (more than three years old) request to fix the column selection: See #66444 - Resolve the column selection conversation

@shreeve

Copy link
Copy Markdown
Contributor Author

Adding alexandrudima, to see if he can help.

@isidorn

Copy link
Copy Markdown

Steve Shreeve (@shreeve) pinging vscode engineers on issues in hope that we will fix it does not really make sense so please stop doing that.
alexandrudima probably has a good reason why he did not implement this feature thus far and he can comment on the PR when he finds time.

@shreeve

Copy link
Copy Markdown
Contributor Author

No worries. Thanks.

In conjunction with setting `editor.multiCursorModifier` to `ctrlCmd`, this yields a much more natural `alt+click` experience. The goofier `shift+alt+click` that is the default uses the _prior_ cursor position as the start point of the column selection.
@alexdima

Copy link
Copy Markdown
Member

👍 This works great and is blatantly simple! Thank you!

@alexdima
Alexandru Dima (alexdima) merged commit d8529d7 into microsoft:master Feb 14, 2019
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants