Skip to content

Update copyFiles.ts - #250773

Merged
Matt Bierner (mjbvz) merged 4 commits into
microsoft:mainfrom
Fs2qFtoS:main
Jun 23, 2025
Merged

Matt Bierner (mjbvz) merged 4 commits into
microsoft:mainfrom
Fs2qFtoS:main

Conversation

@Fs2qFtoS

Copy link
Copy Markdown
Contributor

add isoTime to markdown extension copy file destination options.
I guess many people need that (e.g., me)

@DhruvTheDev1 Dhruv (DhruvTheDev1) left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall — adding isoTime is a nice touch for more readable timestamps when copying files.

@mjbvz Matt Bierner (mjbvz) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't seem to include any code changes

@DhruvTheDev1 Dhruv (DhruvTheDev1) left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

['isoTime', new Date().toISOString()]
Adds a variable 'isoTime' in the resolveCopyDestinationSetting function which lets users include ${isoTime} in the destination path template.

@mjbvz Matt Bierner (mjbvz) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This also needs to be documented in for the settings. Check the markdown-language-features settings json

@DhruvTheDev1

Copy link
Copy Markdown

I opened a follow up PR to document the added isotime variable in the setting description
Update package.nls.json #251706

@mjbvz

Copy link
Copy Markdown
Contributor

Please put all the related changes into a single PR. That helps review and tracking work on the feature

@Fs2qFtoS

Copy link
Copy Markdown
Contributor Author

@ghLcd9dG please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

@vs-code-engineering vs-code-engineering Bot added this to the June 2025 milestone Jun 20, 2025

@Tyriar Daniel Imms (Tyriar) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matt Bierner (@mjbvz) unit tests failing, might need to report the flake to the test owner?

@mjbvz
Matt Bierner (mjbvz) merged commit c663424 into microsoft:main Jun 23, 2025
@vs-code-engineering vs-code-engineering Bot locked and limited conversation to collaborators Aug 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants