Repository navigation
Support variable fonts (#153291) - #153968
Merged
Merged
Conversation
|
|
Luyu Cheng (chengluyu)
changed the title
|
It's been 4 months since this PR was submitted, what's the progress on this? Can we have full variable font support in VSCode yet? |
Contributor
Author
|
mitsukuri I've been also waiting for responses from team members. |
Alexandru Dima (alexdima)
self-requested a review
November 16, 2022 13:35
Alexandru Dima (alexdima)
requested a review
from Henning Dieterichs (hediet)
November 19, 2022 10:32
Alexandru Dima (alexdima)
previously approved these changes
Nov 19, 2022
Contributor
Author
|
Thank you! Is there anything I need to do? |
Henning Dieterichs (hediet)
previously approved these changes
Nov 21, 2022
Member
|
Thanks for the PR! Please merge in main and resolve the merge conflicts (might also conflict with #149703). Thank you! |
Alexandru Dima (alexdima)
dismissed stale reviews from Henning Dieterichs (hediet) and themself
via
November 21, 2022 14:14
c981ea2
Alexandru Dima (alexdima)
approved these changes
Nov 21, 2022
Alex Ross (alexr00)
approved these changes
Nov 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #153291