Repository navigation
Cannot open a folder under my OneDrive folder #27285
Description
I can use Code to open individual files under my OneDrive folder but attempts to open folders does nothing. Attempts to open the OneDrive folder directly does not result in an open folder but creates a new Onedrive file instead.
- VSCode Version: 1.12.2
- OS Version:10.0.16204 Pro and 10.0.16202 Server
Steps to Reproduce:
There are 3 repos:
Repro 1:
- Navigate to a folder under OneDrive from a command prompt.
- Launch code via 'code .'
- Code launches but no folder is open.
Repro 2:
- Launch Code
2: Select File/Open Folder
3: Navigate to a folder under OneDrive and open it.
4: No folder is opened.
Repro 3:
1: Launch Code
2: Select File/Open Folder
3: Navigate to the Onedrive folder and select it.
4: No folder is opened but an empty 'OneDrive' file is created in the editor.
NOTE: The same occurs when running 'code .' from the OneDrive folder, an empty Onedrive file is created in the editor
Activity
roblourens commentedon May 25, 2017
Does it work normally with other editors?
bpasero commentedon May 25, 2017
Please see if you can find any logged output that could help us find the source of the issue:
code --verbosefrom the command line and attach the outputThanks!
dantraMSFT commentedon May 25, 2017
I'm seeing a series of lstat errors in the console. Here are the details...
[uncaught exception]: Error: EINVAL: invalid argument, lstat 'D:\OneDrive'
Error: EINVAL: invalid argument, lstat 'D:\OneDrive'
onError @ index.js:40
(anonymous) @ index.js:109
emitOne @ events.js:96
emit @ events.js:188
window.onerror @ C:\Program Files (x86)\Microsoft VS Code\resources\electron.asar\renderer\init.js:124
i.globals.onerror @ errorTelemetry.ts:64
index.js:43Error: EINVAL: invalid argument, lstat 'D:\OneDrive'
Error: EINVAL: invalid argument, lstat 'D:\OneDrive'
at file:///C:/Program Files (x86)/Microsoft VS Code/resources/app/out/vs/workbench/electron-browser/workbench.main.js:28:22576
onError @ index.js:43
(anonymous) @ index.js:109
emitOne @ events.js:96
emit @ events.js:188
window.onerror @ C:\Program Files (x86)\Microsoft VS Code\resources\electron.asar\renderer\init.js:124
i.globals.onerror @ errorTelemetry.ts:64
errors.ts:33Uncaught Error: EINVAL: invalid argument, lstat 'D:\OneDrive'
Error: EINVAL: invalid argument, lstat 'D:\OneDrive'
at file:///C:/Program Files (x86)/Microsoft VS Code/resources/app/out/vs/workbench/electron-browser/workbench.main.js:28:22576
bpasero commentedon Jun 11, 2017
Dan Travison (@dantraMSFT) I just tried to reproduce with my OneDrive folder and could not. Would you be willing to try to reproduce this running out of sources? As outlined here: https://github.com/Microsoft/vscode/wiki/How-to-Contribute#build-and-run-from-source
bpasero commentedon Jun 15, 2017
DanTravison Dan Travison (@dantraMSFT) Ares Chen (@chenxizhang) kevin12314 can you please try again with our insider build from today and report back any errors you see?
You can give our preview releases a try from: http://code.visualstudio.com/Download#insiders
dantraMSFT commentedon Jun 15, 2017
Doing so now.
yzhang-gh commentedon Jun 16, 2017
Same here (cannot open folder in OneDrive, will open a new file with the folder name)
(cannot even open a file, will just open a new empty file. Notepad works well)
No error in console. But there is a alert popup "Path doesn't exist on disk" when opening file/folder by
Open File/Foldermenus.Windows Insider Preview build 16215
Visual Studio Code Version 1.14.0-insider
Commit c89a5f6
Date 2017-06-15T05:13:32.497Z
yzhang-gh commentedon Jun 16, 2017
I suspect Files On-Demand feature is to blame.
bpasero commentedon Jun 16, 2017
Dan Travison (@dantraMSFT) any update trying insiders? do you have this "Files on demand" feature enabled?
chenxizhang commentedon Jun 16, 2017
Still not work correctly Benjamin Pasero (@bpasero)
51 remaining items
bpasero commentedon Aug 31, 2017
I just created a build of VS Code that includes Electron 1.7.7 which includes a backport of the fix in libuv (thanks for the backport Cheng (@zcbenz)). Can people hitting the OneDrive issue maybe give this build a try and report back if the problem is fixed?
Thanks
pinoelefante commentedon Aug 31, 2017
Benjamin Pasero (@bpasero) is working with this build
linanw commentedon Aug 31, 2017
Ya, it works. I tested it on Windows 10 build 16251.
Updated:
My Windows later updated to 16278.rs3, it doesn't work any more.
bpasero commentedon Aug 31, 2017
That is good news. Unfortunately we are closing for our 1.16 release this week and it is unlikely that we would include this Electron version in the stable release. But we plan to update Electron for insiders next week asap so that people have a workaround by using VS Code insiders.
MaximoTrinidad commentedon Aug 31, 2017
I think someone make sure to test this on the latest Windows 10 Insider Build 16257.rs3. Just in case!
The reason I'm mentioning about it is due to the fact that OneDrive gets updated in one of the recent releases.
:)
zhangyz1997 commentedon Sep 1, 2017
Worked in build 16273 RS4
bk147 commentedon Sep 6, 2017
Also works here on Windows 10 Ent build 16353.rs_prerelease and OneDrive build 17.3.6998.0830 :-)
bpasero commentedon Sep 8, 2017
Fixed via electron/electron#10377
bpasero commentedon Sep 28, 2017
Marking as verified based on user testing.