Change github.copilot.chat.agent.terminal.allowList to chat.agent.terminal.allowList #253314

Activity

1. Daniel Imms (Tyriar)

   added this to the June 2025 milestone on Jul 1, 2025
2. Daniel Imms (Tyriar)

   self-assigned this

   on Jul 1, 2025
3. Daniel Imms (Tyriar)

   added

   bugIssue identified by VS Code Team member as probable bugIssue identified by VS Code Team member as probable bug

   chat-terminalThe run in terminal tool in chatThe run in terminal tool in chat

   on Jul 1, 2025
4. Daniel Imms (Tyriar)

   modified the milestones: June 2025, July 2025 on Jul 2, 2025
5. Bashamega commented on Jul 4, 2025

   

   Adam Naji (Bashamega)

   on Jul 4, 2025

   More actions

   Hello Daniel Imms (@Tyriar)
   I would like to work on this.
   Should I just rename the it in the copilot chat codebase?
6. Tyriar commented on Jul 7, 2025

   

   Daniel Imms (Tyriar)

   on Jul 7, 2025

   ContributorAuthor

   More actions

   Adam Naji (@Bashamega) sorry, this will be done as part of the larger #252650 which will move the entire thing into the microsoft/vscode repo

   👍React with 👍1Reacted by Adam Naji
7. Bashamega commented on Jul 7, 2025

   

   Adam Naji (Bashamega)

   on Jul 7, 2025

   More actions

   No problem Daniel Imms (@Tyriar),
   Do you have any other issue, that I can work on?
8. Tyriar commented on Jul 7, 2025

   

   Daniel Imms (Tyriar)

   on Jul 7, 2025

   ContributorAuthor

   More actions

   Ones labeled good first issue or help wanted are the best ones to contribute to
9. Bashamega commented on Jul 8, 2025

   

   Adam Naji (Bashamega)

   on Jul 8, 2025

   More actions

   Ones labeled good first issue or help wanted are the best ones to contribute to

   Thank you
10. Tyriar commented on Jul 16, 2025

    

    Daniel Imms (Tyriar)

    on Jul 16, 2025

    ContributorAuthor

    More actions

    Fixed in #255804
11. Daniel Imms (Tyriar)

    closed this as completedon Jul 16, 2025
12. Raymond Zhao (rzhao271)

    added

    verifiedVerification succeededVerification succeeded

    and removed

    verifiedVerification succeededVerification succeeded

    on Jul 30, 2025
13. phil294 commented on Aug 24, 2025

    

    Philip Waritschlager (phil294)

    on Aug 24, 2025

    More actions

    apparently it got renamed yet another time to chat.tools.terminal.autoApprove. super annoying to have to fight the settings like this :/
14. Tyriar commented on Aug 24, 2025

    

    Daniel Imms (Tyriar)

    on Aug 24, 2025

    ContributorAuthor

    More actions

    Philip Waritschlager (@phil294) sure, but that's why it was marked experimental so we can ship early for users and work out some of the finer details later. It was actually chat.agent.terminal.autoApprove as well in between, but all of these should now give a warning if you used them:

    vscode/src/vs/workbench/contrib/terminalContrib/chatAgentTools/common/terminalChatAgentToolsConfiguration.ts

    Lines 18 to 22 in 07995d4

    	DeprecatedAutoApproveCompatible = 'chat.agent.terminal.autoApprove',
    	DeprecatedAutoApprove1 = 'chat.agent.terminal.allowList',
    	DeprecatedAutoApprove2 = 'chat.agent.terminal.denyList',
    	DeprecatedAutoApprove3 = 'github.copilot.chat.agent.terminal.allowList',
    	DeprecatedAutoApprove4 = 'github.copilot.chat.agent.terminal.denyList',
15. vs-code-engineering

    locked and limited conversation to collaborators on Aug 31, 2025