Terminal: Run Recent Command shows up when there are no terminals

Repro:

Close all terminals
Run the command, 🐛 nothing happens

We should either hide it or implement it when there isn't a terminal.

Daniel Imms (@Tyriar)

Daniel Imms (@Tyriar) can i help with this issue?

Simone Salerno (@SalerSimo)

Simone Salerno (@SalerSimo) sure! Here's a code pointer:

vscode/src/vs/workbench/contrib/terminalContrib/history/browser/terminal.history.contribution.ts

Lines 141 to 152 in e354996

    
           run: async (activeInstance, c) => { 
        
           	const history = TerminalHistoryContribution.get(activeInstance); 
        
           	if (!history) { 
        
           		return; 
        
           	} 
        
           	await history.runRecent('command'); 
        
           	if (activeInstance?.target === TerminalLocation.Editor) { 
        
           		await c.editorService.revealActiveEditor(); 
        
           	} else { 
        
           		await c.groupService.showPanel(false); 
        
           	} 
        
           }

Daniel Imms (@Tyriar)

Daniel Imms (@Tyriar) I opened a PR for this, can you tell me if the code I wrote is fine? I'm not sure if using a sleep function is accepted here, and, if it's not, I think that the only solution for this issue would be hiding the "Run Recent Command" command when there are no open terminals.

Daniel Imms (@Tyriar)

Daniel Imms (@Tyriar) Since there has been no recent activity on this issue, I have created a PR that addresses this. If you have time, please take a look at the PR and let me know if you have any questions!

Navigation Menu

Repository navigation

Terminal: Run Recent Command shows up when there are no terminals #233604

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	run: async (activeInstance, c) => {
	const history = TerminalHistoryContribution.get(activeInstance);
	if (!history) {
	return;
	}
	await history.runRecent('command');
	if (activeInstance?.target === TerminalLocation.Editor) {
	await c.editorService.revealActiveEditor();
	} else {
	await c.groupService.showPanel(false);
	}
	}

Terminal: Run Recent Command shows up when there are no terminals #233604

Description

Activity

SalerSimo commented on Nov 18, 2024

Tyriar commented on Nov 18, 2024

SalerSimo commented on Nov 21, 2024

Sublimeful commented on Jun 6, 2025

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions