Repository navigation
Typo and formatting nitpicks - #85
Merged
Martin Aeschlimann (aeschli) merged 2 commits intoOct 2, 2017
Merged
Martin Aeschlimann (aeschli) merged 2 commits into
Martin Aeschlimann (aeschli) merged 2 commits into
Conversation
Collaborator
|
Thanks Gilmore Davidson (@gilmoreorless) , that was helpful! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Firstly, great work on the generator; it was really useful for converting a Sublime Text package over to VS Code.
This PR fixes some minor things that I noticed while using the generator. It has two main parts:
vsc-extension-quickstart.mdfiles. The bullet points had a mixture of upper- and lower-case starting letters, and inconsistent application of full stops (periods).I realise the second part is perhaps overly pedantic. If you’d rather accept just the typo fixes without the reformatting, I’m happy to redo the PR to suit (that’s why they’re separate commits 😉).