Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.

Update all dependencies. - #79

Merged
Benjamin Pasero (bpasero) merged 2 commits into
microsoft:masterfrom
JimiC:update_depends
Oct 13, 2017
Merged

Benjamin Pasero (bpasero) merged 2 commits into
microsoft:masterfrom
JimiC:update_depends

Conversation

@JimiC

Copy link
Copy Markdown
Contributor

I checked out what the majority of the dependencies updates was about and it turned out to be dependencies updates, bug fixes, and new features.

I tested this with the editorconfig-vscode extension, in which I contribute by fixing the test cases from time to time, by forcing the vscode package to use the updated dependencies and all looked good.

So I'm confident that there are no breaking changes, but in case I'm horribly wrong, we'll find out pretty quickly.

@bpasero

Benjamin Pasero (bpasero) commented Oct 13, 2017 •

Copy link
Copy Markdown
Contributor

Dimitris "Jimi" Charalampidis (@JimiC) we cannot bump the types for node though, they have to stay in sync with the node.js runtime we ship with in VS Code which today is 7.9.0:

image

@JimiC

Copy link
Copy Markdown
Contributor Author

Benjamin Pasero (@bpasero) Valid point. I had a look on v7 and v8 definitions of @types/node and in order to not confuse any user with types that are not supported from vscode we better ship v7.

@bpasero
Benjamin Pasero (bpasero) merged commit 6500337 into microsoft:master Oct 13, 2017
@bpasero

Copy link
Copy Markdown
Contributor

Thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants