Skip to content

Only normalize the path after expanding. - #4298

Merged
Garrett Campbell (gcampbell-msft) merged 1 commit into
mainfrom
dev/gcampbell/CopyCompileCommandsRegression
Feb 26, 2025
Merged

Garrett Campbell (gcampbell-msft) merged 1 commit into
mainfrom
dev/gcampbell/CopyCompileCommandsRegression

Conversation

@gcampbell-msft

Copy link
Copy Markdown
Collaborator

Trying to normalize the path prior to expanding any macros was causing an edge case to fail.

Fixes #4294

@acyr acyr (acyr) left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that this resolves the issue.

@gcampbell-msft
Garrett Campbell (gcampbell-msft) deleted the dev/gcampbell/CopyCompileCommandsRegression branch February 26, 2025 15:47
Garrett Campbell (gcampbell-msft) added a commit that referenced this pull request Feb 26, 2025
* add changelog, put next patch section of changelog, will update version before release (#4298)

* add notification for uninstalling twxs.cmake (#4299)

* add notification for uninstalling twxs.cmake

* update changelog
Aaron Tan (aarontan-mchp) pushed a commit to aarontan-mchp/vscode-cmake-tools that referenced this pull request May 21, 2025
* add changelog, put next patch section of changelog, will update version before release (microsoft#4298)

* add notification for uninstalling twxs.cmake (microsoft#4299)

* add notification for uninstalling twxs.cmake

* update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Regression] copyCompileCommands not copying the file in 1.20.52 update

3 participants