Skip to content

[liblzma] port uses compromised version #37839

Closed

Description

@marekr

Describe the bug
vcpkg updated liblzma to 5.6.0. This version is known as compromised and backdoored

https://nvd.nist.gov/vuln/detail/CVE-2024-3094
https://www.redhat.com/en/blog/urgent-security-alert-fedora-41-and-rawhide-users

This is a solid 10.0 CVE score vulnerability

vcpkg should immediately revert from 5.6.0

Activity

  1. added
    category:port-bugThe issue is with a library, which is something the port should already support
    on Mar 30, 2024
  2. MichaelCurrie commented on Mar 30, 2024

    @MichaelCurrie

    This PR already addresses the issue by downgrading xz version, but it still leaves the build broken because the entire xz repo has been disabled by GitHub so ALL versions are blocked.

    So, to fix your build, run git pull to sync that fix, and then make this unofficial one-liner change to grab xz from an unofficial mirror.

    image

    Then building will work again:

    .\vcpkg install liblzma:x64-windows
    
  3. carsten-grimm commented on Mar 30, 2024

    @carsten-grimm
    Contributor

    This PR already addresses the issue by downgrading xz version, but it still leaves the build broken because the entire xz repo has been disabled by GitHub so ALL versions are blocked.

    So, to fix your build, run git pull to sync that fix, and then make this unofficial one-liner change to grab xz from an unofficial mirror.

    image

    Then building will work again:

    .\vcpkg install liblzma:x64-windows
    

    If you are using vcpkg in manifest mode with a builtin baseline, you can use an overlay port to implement the suggestion by Michael B. Currie (@MichaelCurrie) .

  4. dg0yt commented on Mar 30, 2024

    @dg0yt
    Contributor

    to implement the suggestion by Michael B. Currie (@MichaelCurrie)

    ... until that fork is taken down for the same reasons as the official repo.

  5. carsten-grimm commented on Mar 30, 2024

    @carsten-grimm
    Contributor

    to implement the suggestion by Michael B. Currie (@MichaelCurrie)

    ... until that fork is taken down for the same reasons as the official repo.

    Yes. I am sure the folks involved do not make these decisions lightly. I hope there will be an actual solution soon.

  6. Neustradamus commented on Mar 30, 2024

    @Neustradamus

    The official XZ team announcement is here:

    Important to know: There is no problem with contributors here like Dr.-Ing. Carsten Grimm (@carsten-grimm).

    But several people mix all because I have requested the XZ update in vcpkg.
    I have received a lot of bad messages (private and public).
    I have no link with XZ project, I follow only the project and do announcement or/and update requests.
    I have requested 5.4.5 and 5.6.0 because there was only 5.4.4 in vcpkg.

    Gowtham (@gowthamgts) has participated on Reddit against me badly and I have commented on two places where he has commented (on my SCRAM request publications):

    You can look here the original comment:

    You can follow my announcements here:

    The good point, people speak about SCRAM "Salted Challenge Response Authentication Mechanism" security ;)

    Badly, some people or projects like only old unsecure mechanisms, some would like security improvements.

  7. changed the title [-]liblzma port uses compromised version[/-] [+][liblzma] port uses compromised version[/+] on Apr 1, 2024
  8. blessio commented on Apr 3, 2024

    @blessio

    This PR already addresses the issue by downgrading xz version, but it still leaves the build broken because the entire xz repo has been disabled by GitHub so ALL versions are blocked.

    So, to fix your build, run git pull to sync that fix, and then make this unofficial one-liner change to grab xz from an unofficial mirror.

    image

    Then building will work again:

    .\vcpkg install liblzma:x64-windows
    

    You may have to not only reinstall the library as explained in the above (THANKS! Michael B. Currie (@MichaelCurrie)). But also:

    1. clean the vcpkg cache
      How do I safely clean vcpkg archives and disable it? #14157 ( on windows this is to delete C:\Users\AppData\Local\vcpkg\archives - on other platforms please search the internet )
    2. update the file portfile.cmake as explained above in all subfolders of VCPKG_ROOT\buildtrees\versioning_\versions\liblzma\
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    category:port-bugThe issue is with a library, which is something the port should already support

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions