Repository navigation
Detail view feedback #590
Description
Improvements:
Resizable e.g. https://www.fluentui-blazor.net/SplitterPosition and size are rememberedTogglable e.g.Click View for environment variables on service1 shows the viewClick View for environment variables on service1 now hides the view
Indication of what is open e.g. clicking View for environment variables on service1 then highlights the button. Probably should wait until we decide how the detail view is opened (button vs row) before spending time on thisMoved to Standardize grid selection and selected row display #1081Detail view settings are remembered when switching between data. e.g.Moved to Details views should remember their state #1080Click View for environment variables on service1Select unhide values buttonClick View for environment variables on service2. The unhide values setting is rememberedWhether values are hidden, column sizes, filter text should be remembered. Doesn't need to persist between reload
Activity
JamesNK commentedon Oct 31, 2023
cc Tim Mulholland (@tlmii)
tlmii commentedon Oct 31, 2023
All great feedback and pretty in line with what I was thinking. A few quick comments now:
This was always the goal, but we need some improvements to the splitter - e.g. being able to hide the splitter bar and secondary panel. I've got notes on it from my testing, need to file an issue.
With the current button I think this makes sense, but it doesn't feel quite right if we do row selection (which I think is the goal). I'm not against it though.
I've got this working now, under the assumption we will do row selection. Even with the button, though, the selected row indication is nice. Just need to pick the appropriate shade of gray...
danmoseley commentedon Nov 12, 2023
Tim Mulholland (@tlmii) is there any remaining piece that isn't on your plate (the splitter)? looking for issues to label help wanted
tlmii commentedon Nov 13, 2023
Dan Moseley (@danmoseley) I've got a few pieces of this in flight at the moment, will likely have PRs Monday/Tuesday. I'll split off remaining work into other issues and they'd likely be good for help wanted
tlmii commentedon Nov 16, 2023
Some of this feedback has been addressed. Still need to address (or split off issues for) the rest, probably starting with how selection happens (e.g. full row selection for all grids like we have for spans?). That might be a topic to do in conjunction with #892 if we're making significant changes to both the summary and details views there.
tlmii commentedon Nov 28, 2023
Closing this issue as things are either fixed (first two bullet points) or have individual issues for them (last two bullet points)