Skip to content

Use an azure key vault to store Github tokens for automated pull requests & release creation - #41158

Merged
Blue (OneBlue) merged 5 commits into
masterfrom
user/oneblue/kv
Jul 24, 2026
Merged

Use an azure key vault to store Github tokens for automated pull requests & release creation#41158
Blue (OneBlue) merged 5 commits into
masterfrom
user/oneblue/kv

Conversation

@OneBlue

Copy link
Copy Markdown
Collaborator

Summary of the Pull Request

PR Checklist

  • Closes: Link to issue #xxx
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated if needed and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: Added/updated if needed
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Note that the service connection & keyvault name cannot be secrets, since they need to be known compile time

Validation Steps Performed

Copilot AI review requested due to automatic review settings July 23, 2026 22:41
@OneBlue
Blue (OneBlue) requested a review from a team as a code owner July 23, 2026 22:41

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates WSL’s Azure Pipelines definitions to source GitHub automation tokens from an Azure Key Vault instead of pipeline variables, aligning credential storage with centralized secret management.

Changes:

  • Added AzureKeyVault@2 steps to retrieve GithubPRToken for automated PR creation in the notice and nightly localization pipelines.
  • Added AzureKeyVault@2 step to retrieve GithubReleaseToken for automated GitHub release creation in the flight stage.
  • Updated the release-creation step to use the Key Vault-provided variable name ($(GithubReleaseToken)).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
.pipelines/wsl-build-notice.yml Fetches GithubPRToken from Key Vault before running the automated “create change” PR step.
.pipelines/wsl-build-nightly-localization.yml Fetches GithubPRToken from Key Vault (gated to Schedule/Manual) for automated localization PR creation.
.pipelines/flight-stage.yml Fetches GithubReleaseToken from Key Vault and wires it into the GitHub release creation step.

@OneBlue
Blue (OneBlue) merged commit c82a43b into master Jul 24, 2026
12 checks passed
@OneBlue
Blue (OneBlue) deleted the user/oneblue/kv branch July 24, 2026 21:54
Blue (OneBlue) added a commit that referenced this pull request Aug 14, 2026
* Mount plugin folders on behalf of the user owning the wsl session (#41331)

* Ignore GSL warning (#40560)

* Use an azure key vault to store Github tokens for automated pull requests & release creation (#41158)

* Experiment with keyvault

* Iterate

* Iterate

* Prepare for PR

* Fix bad merge

---------

Co-authored-by: JohnMcPMS <johnmcp@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants