Skip to content

Fix various issues in the distro validation script - #41141

Merged
Blue (OneBlue) merged 1 commit into
masterfrom
user/oneblue/system-units-fix
Jul 23, 2026
Merged

Fix various issues in the distro validation script#41141
Blue (OneBlue) merged 1 commit into
masterfrom
user/oneblue/system-units-fix

Conversation

@OneBlue

Copy link
Copy Markdown
Collaborator

Summary of the Pull Request

This change solves various issues that cause the distro validation script not to detect enabled system units correctly.

This change also adds more unit to the discouraged list

PR Checklist

  • Closes: Link to issue #xxx
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated if needed and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: Added/updated if needed
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Copilot AI review requested due to automatic review settings July 22, 2026 18:41
@OneBlue
Blue (OneBlue) requested a review from a team as a code owner July 22, 2026 18:41

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the modern distro validation script to improve detection of enabled systemd units from the distro tarball and expands the set of discouraged systemd units.

Changes:

  • Added systemd-vconsole-setup.service to the discouraged system unit list.
  • Reworked systemd enabled-unit discovery to better resolve symlinks and normalize tar paths.

Comment thread distributions/validate-modern.py
@OneBlue
Blue (OneBlue) merged commit ba177f0 into master Jul 23, 2026
14 checks passed
@OneBlue
Blue (OneBlue) deleted the user/oneblue/system-units-fix branch July 23, 2026 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants