Fix various issues in the distro validation script - #41141
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the modern distro validation script to improve detection of enabled systemd units from the distro tarball and expands the set of discouraged systemd units.
Changes:
- Added
systemd-vconsole-setup.serviceto the discouraged system unit list. - Reworked systemd enabled-unit discovery to better resolve symlinks and normalize tar paths.
Ben Hillis (benhillis)
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This change solves various issues that cause the distro validation script not to detect enabled system units correctly.
This change also adds more unit to the discouraged list
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed