Skip to content

Remove hard-coded password from C# API docs - #41098

Merged
Ben Hillis (benhillis) merged 2 commits into
microsoft:masterfrom
benhillis:user/benhill/fix-guardian-credscan
Jul 16, 2026
Merged

Remove hard-coded password from C# API docs#41098
Ben Hillis (benhillis) merged 2 commits into
microsoft:masterfrom
benhillis:user/benhill/fix-guardian-credscan

Conversation

@benhillis

@benhillis Ben Hillis (benhillis) commented Jul 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Summary

  • replace the CredScan-triggering sample password with a neutral documentation placeholder
  • prevent the Guardian CSCAN-MSFT0090 failure

Validation

  • py -m mkdocs build -f doc\mkdocs.yml

Ben Hillis
Remove hard-coded password from C# API docs
e15f41e 
Copilot-Session: e2b0aa02-4711-4b78-af21-73c1ffa2e16b
@benhillis
Ben Hillis (benhillis) requested a review from a team as a code owner July 16, 2026 21:27
Copilot AI review requested due to automatic review settings July 16, 2026 21:27
Ben Hillis
Simplify registry password example
d020c37 
Copilot-Session: e2b0aa02-4711-4b78-af21-73c1ffa2e16b
Copilot AI reviewed Jul 16, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the C# API documentation sample to avoid embedding a hard-coded registry password, instead sourcing the password from an environment variable to satisfy CredScan/Guardian requirements.

Changes:

  • Replaced the sample’s hard-coded password with REGISTRY_PASSWORD environment variable access in the C# Session.Authenticate example.

Comment thread doc/docs/api-reference/csharp/core-classes/session.md Outdated
Copilot AI review requested due to automatic review settings July 16, 2026 21:29
Copilot AI reviewed Jul 16, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comment thread doc/docs/api-reference/csharp/core-classes/session.md
@benhillis
Ben Hillis (benhillis) enabled auto-merge (squash) July 16, 2026 22:21
@benhillis
Ben Hillis (benhillis) merged commit 293e571 into microsoft:master Jul 16, 2026
11 checks passed
@sundhaug92

Martin Sundhaug (sundhaug92) commented Jul 17, 2026

Copy link
Copy Markdown

d020c37 doesn't fit the title, and basically reverts e15f41e. Why not use the environment variable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@dkbennett David Bennett (dkbennett) dkbennett approved these changes
@Brian-Perkins Brian Perkins (Brian-Perkins) Brian-Perkins approved these changes
@craigloewen-msft Craig Loewen (craigloewen-msft) craigloewen-msft approved these changes
@AmelBawa-msft AmirMS (AmelBawa-msft) AmelBawa-msft approved these changes
@beena352 beena352 beena352 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@benhillis @sundhaug92 @dkbennett @Brian-Perkins @craigloewen-msft @AmelBawa-msft @beena352