Retry to delete WSL distribution shortcut for up to 10 seconds - #41046
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves robustness of WSL distribution uninstall cleanup by adding retry logic when deleting the Start Menu shortcut, addressing intermittent test failures caused by transient ERROR_SHARING_VIOLATION file locks.
Changes:
- Replace single-attempt shortcut deletion with
wsl::shared::retry::RetryWithTimeout(100ms interval, 10s timeout) gated to retry only onERROR_SHARING_VIOLATION. - Preserve best-effort behavior by catching/logging failures after retries rather than failing distribution deletion.
Ben Hillis (benhillis)
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This change updates the shortcut deletion logic to retry for up to 10 seconds.
We've seen test failures where the shortcut failed to delete with
ERROR_SHARING_VIOLATION. Retrying for a small amount of time should solve the issue and stabilize the testsPR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed