Log an error when connect() fails in the NAT mode relay - #41033
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds diagnostic logging to the Linux-side localhost/NAT relay path to capture additional context when a TCP connect() attempt fails, helping root-cause intermittent test failures where the relay cannot connect to the requested loopback port.
Changes:
- Log an explicit error when
connect()fails while establishing the relay TCP connection. - Include the requested port, socket family, and
errnoin the log message for troubleshooting.
Ben Hillis (benhillis)
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
We've seen a couple test failure where the NAT relay fails to connect. This change adds logging with more information to help us root cause this issue.
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed