<utility>: make unreachable() call the doom function in debug mode - #6159
Merged
Stephan T. Lavavej (StephanTLavavej) merged 7 commits intoMar 31, 2026
Merged
Conversation
Stephan T. Lavavej (StephanTLavavej)
added
the
enhancement
|
Yes, this just tripped me up. I used |
Stephan T. Lavavej (StephanTLavavej)
changed the title
<utility>: attempt to call doom function on unreachable() call in a debug configuration<utility>: make unreachable() call the doom function in debug mode
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Mar 31, 2026
Stephan T. Lavavej (StephanTLavavej)
moved this from Initial Review
to Ready To Merge
in STL Code Reviews
Member
|
I'm mirroring this to the MSVC-internal repo. Please notify me if any further changes are pushed, otherwise no action is required. |
Stephan T. Lavavej (StephanTLavavej)
moved this from Ready To Merge
to Merging
in STL Code Reviews
Stephan T. Lavavej (StephanTLavavej)
merged commit Mar 31, 2026
a393a18
into
microsoft:main
49 checks passed
Member
🦹♂️ ☠️ 🪲 |
|
Alex Guteniev (@AlexGuteniev) thanks again for your work! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #6151.
In debug mode,
unreachable()will deterministically call the doom function. In release mode, users get the UB they asked for.Extract doom function to a new core header to achieve that. As A. Jiang (@frederick-vs-ja) suggested, core headers do call some functions. In this case, a function will be called by default for
/clrconfigurations only.Extended test coverage to make sure the machinery does not break compilation.
No runtime coverage -- it is still UB to call
unreachable()according to the Standard.