<optional>: Extend compiler bug workaround to MSVC - #5407
Merged
Stephan T. Lavavej (StephanTLavavej) merged 1 commit intoApr 22, 2025
Merged
Conversation
Stephan T. Lavavej (StephanTLavavej)
added
the
enhancement
Stephan T. Lavavej (StephanTLavavej)
requested a review
from a team
as a code owner
April 14, 2025 02:27
Stephan T. Lavavej (StephanTLavavej)
moved this from Initial Review
to Final Review
in STL Code Reviews
David Justo (davidmrdavid)
approved these changes
Apr 17, 2025
Stephan T. Lavavej (StephanTLavavej)
moved this from Final Review
to Ready To Merge
in STL Code Reviews
Stephan T. Lavavej (StephanTLavavej)
moved this from Ready To Merge
to Merging
in STL Code Reviews
Member
Author
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#5369 revealed VSO-2444237 "[RWC][prod/fe][std:c++latest][Regression] LLVM failed with Assertion failed:
ParseTree::Utility::SigStack::sigStack.size() == 1".Xiang Fan (@xiangfan-ms) tracked this down to the introduction of
_Derived_from_optionaland reduced it to a library-free repro. The compiler is having trouble with the lambda's templated function call operator.To unblock our Real World Code test suite, we should extend the workaround we're currently using for EDG to also cover MSVC.