You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
CMake build enables all compiler warnings when building with clang-cl #2448
Describe the bug
When building zstd using clang-cl, the LLVM MSVC-compatible driver, zstd's CMake build emits a very large number of compiler warnings, because zstd's build incorrectly passes -Wall to the compiler. [Source]
For compatibility with MSVC, when -Wall is passed to clang-cl, it's translated to -Weverything.
Note that when using clang-cl, CMake sets CMAKE_C_COMPILER_ID to "Clang" and MSVC to TRUE.
To Reproduce
In a MSVC developer prompt with cmake, ninja and clang-cl available on PATH:
Activity
terrelln commentedon Apr 30, 2021
We don't have the setup to test this, but we would be happy to accept a PR that fixes this issue!