Skip to content

Add a function that generates an SP initiated SSO request - #19

Merged
mbg merged 1 commit into
mbg:masterfrom
herp-inc:sp-initiated
Sep 22, 2022
Merged

mbg merged 1 commit into
mbg:masterfrom
herp-inc:sp-initiated

Conversation

@fumieval

Copy link
Copy Markdown
Contributor

This PR adds a basic support for SP-initiated flow. I confirmed that it works with Google Workspace

@mbg mbg left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like most of new the Haskell file is formatted using Ormolu (or similar), although there is some inconsistent indentation. It would be good if the formatting could be more in line with the other files, as per the contribution guidelines for style.

Comment thread wai-saml2.cabal Resolved
Comment thread src/Network/Wai/SAML2/Request.hs Resolved
Comment thread src/Network/Wai/SAML2/Request.hs Resolved
Comment thread src/Network/Wai/SAML2/Request.hs Resolved
@fumieval
fumieval force-pushed the sp-initiated branch 2 times, most recently from b07ddac to c09c639 Compare September 21, 2022 04:16
@mbg

mbg commented Sep 22, 2022

Copy link
Copy Markdown
Owner

@fumieval Thanks for your work on this and the changes you have made in response to the review. It seems that the formatting and documentation are still outstanding. Is that something you are still planning to do? If not, I can deal with the documentation and re-format the code.

@fumieval
fumieval force-pushed the sp-initiated branch 2 times, most recently from 2fcfc64 to 6379cb9 Compare September 22, 2022 08:57
@fumieval

Copy link
Copy Markdown
Contributor Author

I'm afraid I'm not really sure what the issues with documentation and formatting are. Could you reformat the code?

@mbg
mbg merged commit 45c45df into mbg:master Sep 22, 2022
@mbg

mbg commented Sep 22, 2022

Copy link
Copy Markdown
Owner

No problem and thanks for this contribution! :) I have merged it and pushed my changes on top. You may wish to have a look over those to make sure all is good with you as well.

@fumieval

Copy link
Copy Markdown
Contributor Author

Thank you for making up the documentation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants