Repository navigation
Refactor internal object creation - #458
Merged
masesdevelopers merged 1 commit intoFeb 27, 2026
Merged
Conversation
Make property value parameters nullable (object?[]) in Avro/Protobuf/Default value containers and propagate nullability across related APIs. Replace reflection ConstructorInfo invocations with compiled Expression-based factories for creating TValueContainer and IKafkaRowBag instances in EntityTypeProducer and KafkaTable to reduce reflection overhead and simplify generics. Update IKafkaRowBag and KafkaRowBag to expose typed GetKey/GetValue methods and adapt callers accordingly. Also add minor ownership/field adjustments to align with the new factory-based construction.
masesdevelopers
added
enhancement
masesdevelopers
deleted the
455-use-a-more-speedy-approach-instead-of-new
branch
February 27, 2026 18:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make property value parameters nullable (object?[]) in Avro/Protobuf/Default value containers and propagate nullability across related APIs. Replace reflection ConstructorInfo invocations with compiled Expression-based factories for creating TValueContainer and IKafkaRowBag instances in EntityTypeProducer and KafkaTable to reduce reflection overhead and simplify generics. Update IKafkaRowBag and KafkaRowBag to expose typed GetKey/GetValue methods and adapt callers accordingly. Also add minor ownership/field adjustments to align with the new factory-based construction.
Related Issue
close #455
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: