Repository navigation
[13.x] Fix queue:retry with non-scalar failed job ids - #62208
Merged
Merged
Conversation
|
Thanks for submitting a PR! Note that draft PRs are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
GromNaN
marked this pull request as ready for review
October 27, 2026 12:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DatabaseFailedJobProvider::ids()returns the rawidvalues from the table. When they are not scalar, such as MongoDBObjectIdinstances,queue:retry allthrows aTypeErrorinRetryCommand, because it uses each id as an array key.framework/src/Illuminate/Queue/Console/RetryCommand.php
Line 59 in f3adacd
This casts non-integer ids to strings in
ids(). Integer ids are kept as is, so existing drivers behave the same. TheFailedJobProviderInterfaceand the other providers now document the scalar ids.Fixes mongodb/laravel-mongodb#3626