Repository navigation
[13.x] Ensure _error_bag input is a string in Handler::invalid() - #62147
Merged
Merged
Conversation
binaryfire
added a commit
to hypervel/components-backup
that referenced
this pull request
Oct 26, 2026
Apply laravel/framework#62147 (f1c10664f4). Use the submitted error bag only when it is a string; otherwise retain the exception default. Preserve sessionless response handling. Port both upstream cases using an initialized redirect response for Hypervel response finalization, and align the existing input mock. The regression reproduces the array TypeError without the fix. Handler tests, formatting and full analysis pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In
Illuminate\Foundation\Exceptions\Handler::invalid(), the request's_error_baginput is passed directly toRedirectResponse::withErrors()as the error bag key without verifying that it is a string:If a non-JSON request fails validation and includes an array value for
_error_bag(e.g.,POST /formwith_error_bag[]=x),$request->input('_error_bag', $exception->errorBag)returns an array (['x']). WhenRedirectResponse::withErrors()passes this key toViewErrorBag::put($key, $value), PHP throws an unhandledTypeError(Cannot access offset of type array on arrayat$this->bags[$key] = $bag;), resulting in a 500 Internal Server Error and triggering exception reporting instead of redirecting back with validation errors.Fix
Ensure
$request->input('_error_bag')is a string before using it as the error bag name, falling back to$exception->errorBagotherwise (matching theis_string()guards used for request input inVerifyCsrfToken::tokensMatch()andCursor::fromEncoded()).