Repository navigation
[13.x] Fix simple paginator ignoring page name - #62128
Merged
Merged
Conversation
binaryfire
added a commit
to hypervel/components-backup
that referenced
this pull request
Oct 26, 2026
Apply laravel/framework#62128 (0ee9ca28ce). Paginator already forwards its configured page name. Consolidate the existing test under the upstream case, resolving distinct values for page and comments while retaining the stronger URL and argument assertions. Framework cleanup owns the resolver reset. PaginatorTest and formatting pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The simple
Paginatordoesn't pass itspageNamewhen resolving the current page, so a custom page name is ignored and it always reads?page.LengthAwarePaginatoralready does this (#15870), this does the same here.